Add unit tests for internal/focus package#72
Merged
greynewell merged 1 commit intomainfrom Apr 8, 2026
Merged
Conversation
The focus package had zero test coverage. New tests cover: - pathMatches() helper (exact, suffix, dot-slash prefix) - extract() core logic: file lookup, imports BFS, functions/callees, CalledBy population, self-call exclusion - Relationship type case regression guard: verifies uppercase rel types (DEFINES_FUNCTION, CALLS) do not match, confirming the #68 fix - render() for both JSON and markdown output formats Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
WalkthroughA new test file was added to comprehensively test the focus handler's internal functions: Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested reviewers
Poem
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
focuspackage had zero test coverage despite being used by both thefocusCLI command and the MCPget_graph-adjacent functionality. These tests were added alongside the bug fixes in #68 (relationship type case normalization).pathMatches()— exact, suffix, and./-prefix variantsextract()— file lookup, imports BFS traversal, function/callee population,CalledBypopulation, self-call exclusionDEFINES_FUNCTION,CALLS) produce no results — documents and locks in the fix(focus,find): fix relationship type case, empty CalledBy/Imports, stale API #68 fixrender()— JSON and markdown output modesTest plan
go test ./internal/focus/...— 19 tests, all passgo build ./...passes🤖 Generated with Claude Code
Summary by CodeRabbit