Skip to content

revert: remove skill command (needs redesign)#122

Merged
jonathanpopham merged 1 commit intosupermodeltools:mainfrom
jonathanpopham:revert/skill-command
Apr 13, 2026
Merged

revert: remove skill command (needs redesign)#122
jonathanpopham merged 1 commit intosupermodeltools:mainfrom
jonathanpopham:revert/skill-command

Conversation

@jonathanpopham
Copy link
Copy Markdown
Contributor

@jonathanpopham jonathanpopham commented Apr 13, 2026

Reverts #119. The skill prompt only covered three-file format and didn't account for single .graph files. Needs a redesign before shipping — the prompt needs to cover both formats and we need to decide the right delivery mechanism (skill command, CLAUDE.md injection, hook, etc).

Summary by CodeRabbit

  • Chores
    • Removed the skill subcommand from the CLI.

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Apr 13, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: b24c797b-b296-4798-9f41-363ff199be2d

📥 Commits

Reviewing files that changed from the base of the PR and between 67c495a and d0936c9.

📒 Files selected for processing (1)
  • cmd/skill.go
💤 Files with no reviewable changes (1)
  • cmd/skill.go

Walkthrough

This PR removes the skill subcommand from the CLI tool. Specifically, it deletes the entire cmd/skill.go file that contained the command definition, its help text (called skillPrompt), and the registration logic that made it available when running the CLI.

Changes

Cohort / File(s) Summary
Skill subcommand removal
cmd/skill.go
Deleted the skill Cobra subcommand implementation, including the skillPrompt text and init() function that registered it with rootCmd.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

Suggested reviewers

  • greynewell

Poem

✨ A skill once lived in the CLI,
With prompts so wise and guidance nigh,
But now it bids the code goodbye—
Clean deletions make us sigh. 🧹

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Description check ❓ Inconclusive The description is incomplete—it lacks the required Test plan section with checkboxes for make test, make lint, and manual testing verification. Add the Test plan section with checkboxes confirming make test passes, make lint passes, and describe any manual testing performed.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and specifically describes the main change: reverting the skill command removal with the reason that it needs redesign.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@jonathanpopham jonathanpopham merged commit 6f641cd into supermodeltools:main Apr 13, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant