Skip to content

WebXR: check for null render target (#15)#17

Merged
dmarcos merged 1 commit intosupermedium:devfrom
idrisshah:dev
Jan 18, 2024
Merged

WebXR: check for null render target (#15)#17
dmarcos merged 1 commit intosupermedium:devfrom
idrisshah:dev

Conversation

@idrisshah
Copy link

@idrisshah idrisshah commented Jan 18, 2024

Related issue: #15

Description

Aframes does not render WebXR on Magic Leap browser. Magic Leap browser use WebXR layers but does not use OCULUS_multiview extension. As a result there is null check crash, when rendering an Aframes written WebXR content. Proposing a simple fix to resolve this issue.

This contribution is funded by Magic Leap

@idrisshah
Copy link
Author

idrisshah commented Jan 18, 2024

@dmarcos Can you please review this pull request? This is a missing check in OCULUS_multiview extension usage patch. It breaks WebXR for Magic Leap browser.

@dmarcos
Copy link
Member

dmarcos commented Jan 18, 2024

@idrisshah Thanks so much. Has this been submitted to three repo? We might just need to rebase our fork?

@idrisshah
Copy link
Author

idrisshah commented Jan 18, 2024

No, as i can see, the patch that causes WebXR to break was only merged to supermedium threejs. 2988e59. threejs repo does not have that patch.

@dmarcos
Copy link
Member

dmarcos commented Jan 18, 2024

Thanks so much!

@dmarcos dmarcos merged commit 0cc86c8 into supermedium:dev Jan 18, 2024
@github-actions
Copy link

github-actions bot commented Jan 18, 2024

📦 Bundle size

Full ESM build, minified and gzipped.

Filesize dev Filesize PR Diff
664.5 kB (164.8 kB) 664.5 kB (164.8 kB) +0 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Filesize dev Filesize PR Diff
456.9 kB (110.7 kB) 456.9 kB (110.7 kB) +0 B

@idrisshah
Copy link
Author

idrisshah commented Jan 25, 2024

@dmarcos Can you tell when this change will be in production? None of the webxr AFrame samples works without this change. Thanks

dmarcos pushed a commit that referenced this pull request Jan 25, 2024
@idrisshah @dmarcos
WebXR: check for null render target (#15) (#17)
fb780a8
@dmarcos
Copy link
Member

dmarcos commented Jan 26, 2024

It will ship on next major version (1.6.0). I bumped super-three on A-Frame repo and you can now at least use master builds that include the fix. You can find the build URLs in the commit messages if you want to try:

https://github.com/aframevr/aframe/commits/master/

dmarcos pushed a commit that referenced this pull request Jan 31, 2024
@idrisshah @dmarcos
WebXR: check for null render target (#15) (#17)
df4259e
dmarcos pushed a commit that referenced this pull request Feb 29, 2024
@idrisshah @dmarcos
WebXR: check for null render target (#15) (#17)
35b20d1
dmarcos pushed a commit that referenced this pull request Apr 1, 2024
@idrisshah @dmarcos
WebXR: check for null render target (#15) (#17)
963097e
dmarcos pushed a commit that referenced this pull request May 3, 2024
@idrisshah @dmarcos
WebXR: check for null render target (#15) (#17)
c7e8984
dmarcos pushed a commit that referenced this pull request Jun 3, 2024
@idrisshah @dmarcos
WebXR: check for null render target (#15) (#17)
e6757d2
dmarcos pushed a commit that referenced this pull request Jul 26, 2024
@idrisshah @dmarcos
WebXR: check for null render target (#15) (#17)
1b63a26
dmarcos pushed a commit that referenced this pull request Sep 5, 2024
@idrisshah @dmarcos
WebXR: check for null render target (#15) (#17)
80339ad
dmarcos pushed a commit that referenced this pull request Sep 27, 2024
@idrisshah @dmarcos
WebXR: check for null render target (#15) (#17)
75ab6d5
dmarcos pushed a commit that referenced this pull request Oct 22, 2024
@idrisshah @dmarcos
WebXR: check for null render target (#15) (#17)
6aecdb6
dmarcos pushed a commit that referenced this pull request Nov 8, 2024
@idrisshah @dmarcos
WebXR: check for null render target (#15) (#17)
aa31cd4
dmarcos pushed a commit that referenced this pull request Nov 8, 2024
@idrisshah @dmarcos
WebXR: check for null render target (#15) (#17)
6ab3bf7
dmarcos pushed a commit that referenced this pull request Nov 29, 2024
@idrisshah @dmarcos
WebXR: check for null render target (#15) (#17)
1d075ce
dmarcos pushed a commit that referenced this pull request Dec 31, 2024
@idrisshah @dmarcos
WebXR: check for null render target (#15) (#17)
1239bdb
dmarcos pushed a commit that referenced this pull request Jan 31, 2025
@idrisshah @dmarcos
WebXR: check for null render target (#15) (#17)
5b5b032
vincentfretin added a commit to vincentfretin/three.js that referenced this pull request Jan 31, 2025
@vincentfretin
Revert "WebXR: check for null render target (supermedium#15) (superme…
ec6fe4d 
…dium#17)"

This reverts commit 5b5b032.
vincentfretin added a commit to vincentfretin/three.js that referenced this pull request Jan 31, 2025
@vincentfretin
Revert "WebXR: check for null render target (supermedium#15) (superme…
48cbeeb 
…dium#17)"

This reverts commit 5b5b032.
dmarcos pushed a commit that referenced this pull request Feb 2, 2025
@idrisshah @dmarcos
WebXR: check for null render target (#15) (#17)
1aba49d
dmarcos pushed a commit that referenced this pull request Feb 3, 2025
@felixtrz @dmarcos
WebXR: Implement antialiased multiview using OCULUS_multiview (#15)
1123347 
Fix incorrect handling of depth buffer when stencil buffer was enabled

WebXR: check for null render target (#15) (#17)
dmarcos pushed a commit that referenced this pull request Apr 3, 2025
@felixtrz @dmarcos
WebXR: Implement antialiased multiview using OCULUS_multiview (#15)
07ce6a5 
Fix incorrect handling of depth buffer when stencil buffer was enabled

WebXR: check for null render target (#15) (#17)
dmarcos pushed a commit that referenced this pull request Apr 3, 2025
@felixtrz @dmarcos
WebXR: Implement antialiased multiview using OCULUS_multiview (#15)
a7833ef 
Fix incorrect handling of depth buffer when stencil buffer was enabled

WebXR: check for null render target (#15) (#17)
dmarcos pushed a commit that referenced this pull request Jun 14, 2025
@felixtrz @dmarcos
WebXR: Implement antialiased multiview using OCULUS_multiview (#15)
f774034 
Fix incorrect handling of depth buffer when stencil buffer was enabled

WebXR: check for null render target (#15) (#17)
dmarcos pushed a commit that referenced this pull request Jun 14, 2025
@felixtrz @dmarcos
WebXR: Implement antialiased multiview using OCULUS_multiview (#15)
26b2ddf 
Fix incorrect handling of depth buffer when stencil buffer was enabled

WebXR: check for null render target (#15) (#17)
dmarcos pushed a commit that referenced this pull request Oct 21, 2025
@felixtrz @dmarcos
WebXR: Implement antialiased multiview using OCULUS_multiview (#15)
c567ec0 
Fix incorrect handling of depth buffer when stencil buffer was enabled

WebXR: check for null render target (#15) (#17)
dmarcos pushed a commit that referenced this pull request Nov 12, 2025
@felixtrz @dmarcos
WebXR: Implement antialiased multiview using OCULUS_multiview (#15)
9bee41b 
Fix incorrect handling of depth buffer when stencil buffer was enabled

WebXR: check for null render target (#15) (#17)

Fix multiview for WebXRManager, some changes were lost in a previous rebase (#25)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@idrisshah @dmarcos