feat(compactor): allow overriding header timestamp#75
Closed
corylanou wants to merge 1 commit into
Closed
Conversation
Collaborator
Author
|
Closing based on Ben’s guidance: compacted LTX files represent the latest state only, so their header timestamp should remain the last input timestamp. Earliest timestamps aren’t valid PITR targets once L0 files are compacted, so this change would be misleading. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Compactor.HeaderTimestampoverride for the output header timestampWhy
Compacted L1+ files currently inherit the latest input timestamp. For PITR, downstream tools need the earliest timestamp preserved after L0 retention.
Testing
Links