Skip to content

Fix error when doc has no internal ID #289

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
edoversb merged 1 commit into from
Feb 4, 2025
Merged

Fix error when doc has no internal ID #289

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions packages/super-editor/src/core/super-converter/SuperConverter.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -213,6 +213,8 @@ class SuperConverter {
getDocumentInternalId() {
const settings = this.convertedXml['word/settings.xml'];
if (!settings) return '';
if (!settings.elements[0]?.elements) return '';

// New versions of Word will have w15:docId
// It's possible to have w14:docId as well but Word(2013 and later) will convert it automatically when document opened
const w15DocId = settings.elements[0].elements.find((el) => el.name === 'w15:docId');
Expand Down