Skip to content

Conversation

@hunleyd
Copy link
Contributor

@hunleyd hunleyd commented Dec 5, 2025

depends on #1956

- WAL-G configuration is now managed by placing `wal-g.conf` in `/etc/postgresql-custom/conf.d/`.
- This aligns with PostgreSQL's standard practice of including configuration files from `conf.d` subdirectories.
- Direct inclusion of `wal-g.conf` in `postgresql.conf` has been removed.
- PostgreSQL `archive_mode` is now explicitly set to `on` with a no-op `archive_command` in `postgresql.conf.j2`.
Screenshot 2025-12-05 at 13 29 42 Screenshot 2025-12-05 at 13 29 57 Screenshot 2025-12-05 at 13 30 05

✅ docker build
✅ flake check

The `read-replica.conf` file has been moved from `/etc/postgresql-custom/` to `/etc/postgresql-custom/conf.d/`. This change aligns with the standard practice of including configuration snippets from a `conf.d` directory.

Changes include:
- Dockerfiles: Adjusted to remove direct copy and update `sed` commands.
- Ansible: Renamed configuration file and updated task to place it in `conf.d`.
- Nix: Updated paths and substitutions to reflect the new location.
Updates the following versions for improved security and stability:
- PostgreSQL 17 (orioledb-17) to 17.6.0.015
- PostgreSQL 17 to 17.6.1.058
- PostgreSQL 15 to 15.14.1.058

Also updates the checksum for Pgbouncer 1.19.0.
…-260

* 'INDATA-260' of github.com:supabase/postgres:
  chore: [ansible/vars] bumping admin-api version (#1960)
  fix: reserve the port for postgres_exporter with sysctl (#1953)
  chore: Update PostgREST setup and versions (#1955)
  Bump PostgREST to 14.1 (#1909)
* origin/develop:
  chore: prevent loopback ssh connections (#1959)
  chore: rename infra repo (#1958)
* origin:
  feat: Ensure postgres conf.d directory is set up (#1961)
  Multi version ext/pg partman (#1854)
…-260

* 'INDATA-260' of github.com:supabase/postgres:
depends on #1956

- WAL-G configuration is now managed by placing `wal-g.conf` in `/etc/postgresql-custom/conf.d/`.
- This aligns with PostgreSQL's standard practice of including configuration files from `conf.d` subdirectories.
- Direct inclusion of `wal-g.conf` in `postgresql.conf` has been removed.
- PostgreSQL `archive_mode` is now explicitly set to `on` with a no-op `archive_command` in `postgresql.conf.j2`.
* origin:
  refactor: Move read-replica.conf to conf.d (#1956)
  ci: Custom GitHub Runners for Nix Builds (#1745)
  fix: search path and migration grants (#1939)
  chore: bump admin api version (#1964)
@hunleyd hunleyd marked this pull request as ready for review December 8, 2025 21:23
@hunleyd hunleyd requested review from a team as code owners December 8, 2025 21:23
@hunleyd hunleyd requested a review from Copilot December 9, 2025 15:04
@hunleyd hunleyd added this pull request to the merge queue Dec 9, 2025
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR refactors WAL-G configuration management to follow PostgreSQL's standard practice of including configuration files from conf.d subdirectories, rather than explicitly including wal-g.conf in postgresql.conf.

Key changes:

  • WAL-G configuration now resides in /etc/postgresql-custom/conf.d/wal-g.conf instead of /etc/postgresql-custom/wal-g.conf
  • PostgreSQL archive_mode and archive_command are now explicitly set in the main configuration file with a no-op command
  • Direct inclusion of wal-g.conf in postgresql.conf has been removed

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
ansible/tasks/setup-wal-g.yml Updates WAL-G config deployment to use conf.d directory and removes explicit inclusion logic
ansible/files/postgresql_config/postgresql.conf.j2 Adds explicit archive_mode = on and no-op archive_command, removes WAL-G include directive
ansible/files/postgresql_config/conf.d/wal-g.conf Reorganizes configuration settings and removes redundant archive_mode declaration
Dockerfile-orioledb-17 Removes WAL-G config copy and inclusion sed command
Dockerfile-17 Removes WAL-G config copy and inclusion sed command
Dockerfile-15 Removes WAL-G config copy and inclusion sed command

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Merged via the queue into develop with commit 7d4bbf0 Dec 9, 2025
28 checks passed
@hunleyd hunleyd deleted the INDATA-261 branch December 9, 2025 15:59
yvan-sraka pushed a commit that referenced this pull request Dec 9, 2025
* refactor: Move read-replica.conf to conf.d

The `read-replica.conf` file has been moved from `/etc/postgresql-custom/` to `/etc/postgresql-custom/conf.d/`. This change aligns with the standard practice of including configuration snippets from a `conf.d` directory.

Changes include:
- Dockerfiles: Adjusted to remove direct copy and update `sed` commands.
- Ansible: Renamed configuration file and updated task to place it in `conf.d`.
- Nix: Updated paths and substitutions to reflect the new location.

* chore: Update postgres and pgbouncer versions

Updates the following versions for improved security and stability:
- PostgreSQL 17 (orioledb-17) to 17.6.0.015
- PostgreSQL 17 to 17.6.1.058
- PostgreSQL 15 to 15.14.1.058

Also updates the checksum for Pgbouncer 1.19.0.

* refactor: Standardize WAL-G config inclusion

depends on #1956

- WAL-G configuration is now managed by placing `wal-g.conf` in `/etc/postgresql-custom/conf.d/`.
- This aligns with PostgreSQL's standard practice of including configuration files from `conf.d` subdirectories.
- Direct inclusion of `wal-g.conf` in `postgresql.conf` has been removed.
- PostgreSQL `archive_mode` is now explicitly set to `on` with a no-op `archive_command` in `postgresql.conf.j2`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants