-
-
Notifications
You must be signed in to change notification settings - Fork 221
refactor: Standardize WAL-G config inclusion #1965
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The `read-replica.conf` file has been moved from `/etc/postgresql-custom/` to `/etc/postgresql-custom/conf.d/`. This change aligns with the standard practice of including configuration snippets from a `conf.d` directory. Changes include: - Dockerfiles: Adjusted to remove direct copy and update `sed` commands. - Ansible: Renamed configuration file and updated task to place it in `conf.d`. - Nix: Updated paths and substitutions to reflect the new location.
Updates the following versions for improved security and stability: - PostgreSQL 17 (orioledb-17) to 17.6.0.015 - PostgreSQL 17 to 17.6.1.058 - PostgreSQL 15 to 15.14.1.058 Also updates the checksum for Pgbouncer 1.19.0.
…-260 * 'INDATA-260' of github.com:supabase/postgres:
depends on #1956 - WAL-G configuration is now managed by placing `wal-g.conf` in `/etc/postgresql-custom/conf.d/`. - This aligns with PostgreSQL's standard practice of including configuration files from `conf.d` subdirectories. - Direct inclusion of `wal-g.conf` in `postgresql.conf` has been removed. - PostgreSQL `archive_mode` is now explicitly set to `on` with a no-op `archive_command` in `postgresql.conf.j2`.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR refactors WAL-G configuration management to follow PostgreSQL's standard practice of including configuration files from conf.d subdirectories, rather than explicitly including wal-g.conf in postgresql.conf.
Key changes:
- WAL-G configuration now resides in
/etc/postgresql-custom/conf.d/wal-g.confinstead of/etc/postgresql-custom/wal-g.conf - PostgreSQL
archive_modeandarchive_commandare now explicitly set in the main configuration file with a no-op command - Direct inclusion of
wal-g.confinpostgresql.confhas been removed
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| ansible/tasks/setup-wal-g.yml | Updates WAL-G config deployment to use conf.d directory and removes explicit inclusion logic |
| ansible/files/postgresql_config/postgresql.conf.j2 | Adds explicit archive_mode = on and no-op archive_command, removes WAL-G include directive |
| ansible/files/postgresql_config/conf.d/wal-g.conf | Reorganizes configuration settings and removes redundant archive_mode declaration |
| Dockerfile-orioledb-17 | Removes WAL-G config copy and inclusion sed command |
| Dockerfile-17 | Removes WAL-G config copy and inclusion sed command |
| Dockerfile-15 | Removes WAL-G config copy and inclusion sed command |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
* refactor: Move read-replica.conf to conf.d The `read-replica.conf` file has been moved from `/etc/postgresql-custom/` to `/etc/postgresql-custom/conf.d/`. This change aligns with the standard practice of including configuration snippets from a `conf.d` directory. Changes include: - Dockerfiles: Adjusted to remove direct copy and update `sed` commands. - Ansible: Renamed configuration file and updated task to place it in `conf.d`. - Nix: Updated paths and substitutions to reflect the new location. * chore: Update postgres and pgbouncer versions Updates the following versions for improved security and stability: - PostgreSQL 17 (orioledb-17) to 17.6.0.015 - PostgreSQL 17 to 17.6.1.058 - PostgreSQL 15 to 15.14.1.058 Also updates the checksum for Pgbouncer 1.19.0. * refactor: Standardize WAL-G config inclusion depends on #1956 - WAL-G configuration is now managed by placing `wal-g.conf` in `/etc/postgresql-custom/conf.d/`. - This aligns with PostgreSQL's standard practice of including configuration files from `conf.d` subdirectories. - Direct inclusion of `wal-g.conf` in `postgresql.conf` has been removed. - PostgreSQL `archive_mode` is now explicitly set to `on` with a no-op `archive_command` in `postgresql.conf.j2`.
depends on #1956
✅ docker build
✅ flake check