feat(pull): add debug logs for ssl check#4894
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review infoConfiguration used: Central YAML (base), Organization UI (inherited) Review profile: CHILL Plan: Pro Cache: Disabled due to Reviews > Disable Cache setting Disabled knowledge base sources:
⛔ Files ignored due to path filters (1)
📒 Files selected for processing (5)
💤 Files with no reviewable changes (1)
📝 WalkthroughSummary by CodeRabbit
WalkthroughThe pull request refactors and extends the schema diffing infrastructure with enhanced SSL/TLS debugging capabilities. It relocates the Comment |
There was a problem hiding this comment.
Pull request overview
Adds targeted SSL/TLS debugging and adjusts TLS probing behavior to better support environments where certificate verification is intentionally skipped (e.g., SUPABASE_CA_SKIP_VERIFY=true), while avoiding the noise of the general --debug flag.
Changes:
- Add
SUPABASE_SSL_DEBUG-gated debug logs around root CA detection / TLS probing and in migra templates. - When
SUPABASE_CA_SKIP_VERIFY=true, disable additional TLS verification hooks during the TLS-capability probe. - Refactor
diffWithStreamintointernal/db/diff/diff.go(shared helper) and adjust shutdown-error filtering.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| internal/gen/types/types.go | Adds SSL debug logging, URL redaction helper, and expands skip-verify behavior during TLS probe. |
| internal/db/diff/templates/migra.ts | Adds SSL-scoped debug logging and URL redaction for SOURCE/TARGET. |
| internal/db/diff/templates/migra.sh | Adds SSL-scoped debug logging for migra bash wrapper execution. |
| internal/db/diff/pgdelta.go | Removes duplicated diffWithStream helper (now centralized). |
| internal/db/diff/migra.go | Forwards SUPABASE_SSL_DEBUG into containers and logs key SSL-related context. |
| internal/db/diff/diff.go | Centralizes diffWithStream and adjusts filtering of a known edge-runtime shutdown message. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
Pull Request Test Coverage Report for Build 23290441342Details
💛 - Coveralls |
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
What kind of change does this PR introduce?
When
SUPABASE_CA_SKIP_VERIFYis set to true, also skip peer cert check and verify connection.Add a
SUPABASE_SSL_DEBUGflag to allow to debug only SSL related issue while filtering out the noise of the generic--debugflag.