Fix: Place start menu shortcuts under "Programs" Shell folder instead of root#5658
Open
fidel-ying wants to merge 1 commit into
Open
Fix: Place start menu shortcuts under "Programs" Shell folder instead of root#5658fidel-ying wants to merge 1 commit into
fidel-ying wants to merge 1 commit into
Conversation
Replace incorrect CSIDL_COMMON_STARTMENU/CSIDL_STARTMENU with CSIDL_COMMON_PROGRAMS/CSIDL_PROGRAMS and update comments to reflect the Programs folder path. This ensures shortcuts are created in the Start Menu\Programs locations for both all-users and current-user contexts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes an issue where the installer incorrectly creates start menu shortcuts directly in the current user's (or all users') Start Menu root directory, rather than inside the standard "Programs" Shell folder.
In
src/Installer.cpp, the shortcut directory array previously containedCSIDL_COMMON_STARTMENUandCSIDL_STARTMENU. This has been updated to useCSIDL_COMMON_PROGRAMSandCSIDL_PROGRAMSto ensure shortcuts are placed neatly within the appropriate subfolder, aligning with Windows user experience standards.Changes Made
src/Installer.cpp:CSIDL_STARTMENUwithCSIDL_PROGRAMSfor current user shortcuts.CSIDL_COMMON_STARTMENUwithCSIDL_COMMON_PROGRAMSfor all users shortcuts.Verification
...\Start Menu\Programsinstead of cluttering the root Start Menu directory during installation.