Skip to content

fix(storage): refuse newer schemas before writes - #425

Merged
styler-ai merged 5 commits into
mainfrom
fix/410-schema-preflight
Aug 1, 2026
Merged

fix(storage): refuse newer schemas before writes#425
styler-ai merged 5 commits into
mainfrom
fix/410-schema-preflight

Conversation

@styler-ai

@styler-ai styler-ai commented Aug 1, 2026

Copy link
Copy Markdown
Owner

Closes #410

Summary

  • retain the database-owned read-only schema preflight before both primary and telemetry writable connections
  • return one privacy-safe schema_version_mismatch contract through CLI JSON/TOON and real stdio MCP tool errors
  • prove active-WAL refusal leaves database bytes, WAL bytes, sidecars, schema objects, authored state, telemetry, and derived state unchanged
  • make Windows locked-mirror recovery name the stale command/version, verified runtime/version, and exact unlock/rerun/bare-command gates
  • add packaged-runtime and row-count-independent performance proof, keep wide TUI reference tests deterministic, and add the requested About sentence unchanged

Verification

  • cargo fmt --all -- --check
  • cargo check --workspace --all-targets --all-features --locked
  • cargo clippy --workspace --all-targets --all-features --locked -- -D warnings
  • cargo test --workspace --all-features --locked
  • cargo test --doc --workspace --all-features --locked
  • RUSTDOCFLAGS="-D warnings" cargo doc --workspace --no-deps --all-features --locked
  • COLUMNS=80 deterministic overview/reference regressions
  • strict OpenSpec validation, issue-checklist parity, PowerShell AST parse, strict-string and dependency policy gates
  • isolated official-package CLI plus persistent stdio MCP active-WAL proof
  • Windows locked-mirror/unlock/rerun/bare-command installer proof
  • 1-row vs 1,000,000-row refusal profile with identical SQLite VM steps and reads

Review state

Three independent Rust/database/release-gate reviews found no actionable blocker on the implementation. All OpenSpec tasks are complete; exact-head local and hosted gates pass on Linux, Windows, macOS x64, and macOS arm64, all review threads are resolved, and Codex reported no major issues on 7c8e22f.

@styler-ai styler-ai added this to the v0.4.3-00 milestone Aug 1, 2026

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 40d94774b9

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread plugins/projectatlas/scripts/install-runtime.ps1 Outdated
Comment thread crates/projectatlas-cli/src/main.rs Outdated
@styler-ai

Copy link
Copy Markdown
Owner Author

@codex review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 2125f9c027

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread plugins/projectatlas/scripts/install-runtime.ps1
Comment thread plugins/projectatlas/scripts/install-runtime.ps1
Comment thread README.md
@styler-ai

Copy link
Copy Markdown
Owner Author

@codex review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: d140e8e8bd

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread crates/projectatlas-db/src/lib.rs
Comment thread plugins/projectatlas/scripts/install-runtime.ps1 Outdated
@styler-ai

Copy link
Copy Markdown
Owner Author

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Breezy!

Reviewed commit: 53ad80195c

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@styler-ai

Copy link
Copy Markdown
Owner Author

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Already looking forward to the next diff.

Reviewed commit: 7c8e22f065

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@styler-ai
styler-ai merged commit 0425a29 into main Aug 1, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug(upgrade): stale v0.3.26 CLI executes DDL before rejecting schema-16 DB

1 participant