forked from KillingSpark/zstd-rs
-
Notifications
You must be signed in to change notification settings - Fork 1
feat(checksum): content-checksum modes, encoder toggle, off-thread one-shot hashing, wasm bindings #384
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
feat(checksum): content-checksum modes, encoder toggle, off-thread one-shot hashing, wasm bindings #384
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
f8bec64
test(decode): ring-vs-flat decode diagnostic harness
polaz e985de8
perf(decode): allow inline match-copy on contiguous wrapped ring
polaz 3da8d4a
test(decode): ring-only streaming decode loop for profiling
polaz b0b5da8
feat(checksum): add content-checksum modes and encoder toggle
polaz 8100658
feat(wasm): expose content-checksum params and accessors
polaz fd4ffa4
feat(encode): off-thread content checksum for one-shot frames
polaz 80d5293
test(encode): one-shot checksum offload vs inline timing harness
polaz File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix the default checksum mode documentation.
The docs claim the default is
ContentChecksum.EmitOnly, but the Rust implementation atzstd-wasm/src/lib.rslines 42-49 showscore_checksumdefaults toContentChecksum.Noneviamode.unwrap_or(ContentChecksum.None). When the TS side passesundefined, the Rust side receivesNoneand resolves it to theNonevariant.The same issue affects
decompressUsingDict(line 205) and thecreateDecompressStreamJSDoc (line 220).📝 Proposed documentation fix
Apply similar fixes to
decompressUsingDict(around line 201) andcreateDecompressStream(around line 214-218).🤖 Prompt for AI Agents