This repository was archived by the owner on Mar 11, 2025. It is now read-only.
feat: allow engine selection#35
Merged
stringhandler merged 32 commits intostringhandler:mainfrom Mar 6, 2025
Merged
Conversation
Signed-off-by: Rumble Fish <rumblefish@192.168.1.24> Signed-off-by: Misieq01 <bartosz2000walczak@gmail.com>
Signed-off-by: Rumble Fish <rumblefish@192.168.1.24> Signed-off-by: Misieq01 <bartosz2000walczak@gmail.com>
Signed-off-by: Rumble Fish <rumblefish@192.168.1.24> Signed-off-by: Misieq01 <bartosz2000walczak@gmail.com>
We need an updated concensus for the reset
Fix build for cross-compiled platforms - linux-arm64/linux-riscv Seems there is a multi version conflict in getrandom crate
SWvheerden
suggested changes
Feb 7, 2025
SWvheerden
left a comment
There was a problem hiding this comment.
Looking good,
Just a few things
- There are a few files which I think might need to be in the .gitignore file so that it does not need checking in.
- A lot of cfg compiler flags makes later code management hard, I think we can reduce them somewhat so that we don't need so many cfg compiler blocks.
- Some uncommented code left in the code that we should remove.
Closed
stringhandler
approved these changes
Mar 4, 2025
brianp
pushed a commit
to tari-project/universe
that referenced
this pull request
Mar 6, 2025
### [ Summary ] - Added support for managing engine selection - Added option in experimental settings to switch between detected engines - Updated support for new gpu_status_file structure - Stopped using gpu devices from HardwareMonitor ### [ Testing ] - Build new gpu_miner binary from stringhandler/tarigpuminer#35 with `--features nvidia,opencl` for `windows`/`linux` or `--features opencl,metal` for `macos` - Replace current gpu_miner binary in binaries folder - Run tari universe and play around with gpu mining, toggling device exclusion, switching engines <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Added a new GPU engine selection option in the settings with full localization support. - Introduced a dedicated interface element for choosing and updating the GPU engine, streamlining mining configuration. - **Enhancements** - Improved GPU device management with a simplified exclusion toggle and refined mining status updates for a smoother user experience. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Branch created from #31
[ Summary ]
multi_engine_wrapperfor managing used engine depending on user selectiongpu_statusfile logic => Now we are creating one file per engine ( for example CUDA_gpu_status.json )