[feat] Add all components/registry/components/*.json files#6
Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. |
9485588 to
9aa4e8a
Compare
6b662f4 to
114f77c
Compare
114f77c to
ae8249f
Compare
50ac227 to
e0126e4
Compare
280b863 to
eee3176
Compare
e0126e4 to
26c6a3d
Compare
| "docs": null | ||
| }, | ||
| "media": { | ||
| "image": "https://user-images.githubusercontent.com/8137814/221879671-70379d15-81ac-44b9-b267-a8fa3842a0d9.png" |
There was a problem hiding this comment.
suggestion: This image uses user-images.githubusercontent.com. These URLs are generally stable but less permanent than raw.githubusercontent.com URLs from the repo itself.
This affects 16 files in this PR. Not blocking, but noting for future reference. Perhaps worth adding user-images.githubusercontent.com to DISALLOWED_IMAGE_HOSTS if image stability becomes an issue.
Other affected files:
- spacy-streamlit.json
- st-pages.json
- streamlit-bokeh-events.json
- streamlit-chatbox.json
- streamlit-cropper.json
- streamlit-d3graph.json
- streamlit-folium.json
- streamlit-image-annotation.json
- streamlit-image-comparison.json
- streamlit-login-auth-ui.json
- streamlit-lottie.json
- streamlit-scrollable-textbox.json
- streamlit-supabase-auth.json
- streamlit-tags.json
- streamlit-timeline.json
There was a problem hiding this comment.
Great call out! I'm going to leave as-is today since it matches the existing gallery, but agree that we may want to include user-images.githubusercontent.com as a disallowed host in the future!
mayagbarnes
left a comment
There was a problem hiding this comment.
Just some non-blocking questions/suggestions
26c6a3d to
f7de7d5
Compare
782fed3 to
43a613a
Compare
f7de7d5 to
5ea40b3
Compare
43a613a to
a2ea272
Compare
2aba626 to
e9738e7
Compare
000a531 to
a9330b0
Compare
e9738e7 to
21fab7c
Compare
21fab7c to
63546f7
Compare

TL;DR
Added ~200 component JSON files to the directory, matching the existing components from https://streamlit.io/components