fix: rename followup — stale TLA+, book, module names, doc comments, bench labels#956
Conversation
…nts, bench labels 1. TLA+: CommitAdvances → CheckpointAdvances (operator, coverage cfg, README) 2. Book: "SIMD Scanner" → "Scanner" / "Zero-Copy Scanner" in titles, nav, links 3. aggregator.rs → reassembler.rs with backward-compat re-export 4. Kani proofs: verify_aggregator_* → verify_reassembler_*; proptest: aggregator_* → reassembler_* 5. Doc comments: "SIMD scanner" → "scanner" / "zero-copy scanner" 6. bench/scenarios + justfile: tcp_out/udp_out → tcp/udp 7. Benchmark label: "SIMD scanner" → "CopyScanner" 8. VERIFICATION.md: aggregator.rs → reassembler.rs, 5 proofs → 8 proofs 9. Fuzz target: streaming_scanner → zero_copy_scanner 10. GitHub Actions: remove "SIMD" from scanner reference Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Organization UI (inherited) Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (23)
WalkthroughThis pull request performs systematic terminology and naming updates across the codebase. It removes "SIMD" references from documentation and comments, replacing them with more general or accurate descriptions like "scanner" or "zero-copy scanner." The PR renames the Possibly related PRs
Comment |
Summary
Followup to #952 (rename cleanup) fixing stale references found by thorough diff review:
CommitAdvances→CheckpointAdvances(3 files)aggregator.rs→reassembler.rsmodule rename + backward-compat re-export (keepslogfwd_core::aggregator::*working)aggregator_*→reassembler_*bench/scenarios/README.md+justfile:tcp_out/udp_out→tcp/udp"SIMD scanner"→"CopyScanner"VERIFICATION.md: fix proof count 5 → 8, update module namestreaming_scanner.rs→zero_copy_scanner.rsTest plan
cargo checkpassescargo fmtclean🤖 Generated with Claude Code
Note
Rename stale identifiers across TLA+ specs, docs, bench labels, and module names
CommitAdvancesinvariant toCheckpointAdvancesin PipelineMachine.tla, its coverage config, and README.aggregatormodule toreassemblerin logfwd-core, adding apub use reassembler as aggregatorre-export for backward compatibility.fuzz_streaming_scannerfuzz target tofuzz_zero_copy_scannerand updates benchmark labels to match current component names.Macroscope summarized 326880a.