fix: normalize conflict struct columns in OTLP sink before encoding#832
Merged
Conversation
3 tasks
Copilot
AI
changed the title
[WIP] Fix OTLP sink to handle conflict struct columns
fix: normalize conflict struct columns in OTLP sink before encoding
Apr 3, 2026
|
Important Review skippedBot user detected. To trigger a single review, invoke the ⚙️ Run configurationConfiguration used: Repository YAML (base), Organization UI (inherited) Review profile: ASSERTIVE Plan: Free Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
Co-authored-by: strawgate <6384545+strawgate@users.noreply.github.com>
0e4e668 to
19d8173
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OtlpSink::encode_batchsilently dropped any ArrowStruct-typed column viaDataType::Struct(_) => continue, causing data loss for fields with mixed types (which the conflict schema mechanism encodes asStruct).Changes
logfwd-arrow: Movedconflict_schemamodule here fromlogfwd-transformso it's accessible to output crates without a circular dependencylogfwd-transform: Re-exportslogfwd_arrow::conflict_schemafor backward compatibilitylogfwd-output: Addedlogfwd-arrowdependency; callsnormalize_conflict_columnson the batch before the encoding loop so conflictStructcolumns are flattened toUtf8rather than skipped