Fix pre-existing test compilation failures blocking CI#773
Closed
Copilot wants to merge 2 commits into
Closed
Conversation
6 tasks
…or::Passthrough variant, fix tcp_input races, prefix _num_rows Agent-Logs-Url: https://github.com/strawgate/memagent/sessions/f8045f96-6b65-4568-bcee-6d1e23d7fd01 Co-authored-by: strawgate <6384545+strawgate@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix CLI output streams and argument handling issues
Fix pre-existing test compilation failures blocking CI
Apr 3, 2026
Owner
|
Closing: the test compilation errors this PR fixed have already been resolved on master (via #783 and other recent merges). All workspace tests pass on current master. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Six CLI issues (#702, #703, #708, #709, #681, #682) were already addressed in the codebase. The actual CI blocker was four accumulated test compilation errors across unrelated commits.
Fixes
pipeline.rs— Remove unusedNamedSink<T>struct anduse std::iofrom test module; both triggered-D dead-code/-D unused-importserrors at test compile timeframed.rs— Fix 3 EOF-flush tests still usingFormatProcessor::Passthroughas a unit variant after it became a struct variant in fix: increment parse_errors for invalid JSON lines in passthrough JSON mode #755; change toFormatProcessor::passthrough(Arc::clone(&stats))tcp_input.rs— Fix 2 max-line-length tests that assumedclient_count()would be observed as>0. When the kernel socket buffer is large enough to deliver the full 1 MiB payload in one shot, the entire connection lifecycle (accept → read → disconnect) completes inside a singlepoll()call:conflict_schema.rs— Prefix unusednum_rowsbinding with_to suppress-D unused-variablesin test module