Skip to content

Fix pre-existing test compilation failures blocking CI#773

Closed
Copilot wants to merge 2 commits into
masterfrom
copilot/fix-cli-output-and-argument-handling
Closed

Fix pre-existing test compilation failures blocking CI#773
Copilot wants to merge 2 commits into
masterfrom
copilot/fix-cli-output-and-argument-handling

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Apr 3, 2026

Six CLI issues (#702, #703, #708, #709, #681, #682) were already addressed in the codebase. The actual CI blocker was four accumulated test compilation errors across unrelated commits.

Fixes

  • pipeline.rs — Remove unused NamedSink<T> struct and use std::io from test module; both triggered -D dead-code/-D unused-imports errors at test compile time

  • framed.rs — Fix 3 EOF-flush tests still using FormatProcessor::Passthrough as a unit variant after it became a struct variant in fix: increment parse_errors for invalid JSON lines in passthrough JSON mode #755; change to FormatProcessor::passthrough(Arc::clone(&stats))

  • tcp_input.rs — Fix 2 max-line-length tests that assumed client_count() would be observed as >0. When the kernel socket buffer is large enough to deliver the full 1 MiB payload in one shot, the entire connection lifecycle (accept → read → disconnect) completes inside a single poll() call:

    // Before: never true when lifecycle completes in one poll()
    if input.client_count() > 0 { was_connected = true; }
    
    // After: wait for writer thread to signal completion
    if input.client_count() == 0 && writer.is_finished() { break; }
    writer.join().expect("writer thread should have connected and completed");
  • conflict_schema.rs — Prefix unused num_rows binding with _ to suppress -D unused-variables in test module

Copilot AI linked an issue Apr 3, 2026 that may be closed by this pull request
6 tasks
…or::Passthrough variant, fix tcp_input races, prefix _num_rows

Agent-Logs-Url: https://github.com/strawgate/memagent/sessions/f8045f96-6b65-4568-bcee-6d1e23d7fd01

Co-authored-by: strawgate <6384545+strawgate@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix CLI output streams and argument handling issues Fix pre-existing test compilation failures blocking CI Apr 3, 2026
Copilot AI requested a review from strawgate April 3, 2026 02:44
@strawgate strawgate marked this pull request as ready for review April 3, 2026 03:01
@strawgate
Copy link
Copy Markdown
Owner

Closing: the test compilation errors this PR fixed have already been resolved on master (via #783 and other recent merges). All workspace tests pass on current master.

@strawgate strawgate closed this Apr 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

meta: CLI output and argument handling polish

2 participants