fix: Parse criterion output in bench workflow#17
Merged
Conversation
Add two new DataFusion scalar UDFs for structured log parsing:
- regexp_extract(string, pattern, group_index): Spark-compatible regex
extraction returning capture group at given index (0=full match, 1+=groups)
- grok(string, pattern): Logstash-style grok pattern parsing returning a
Struct with one field per named capture (%{PATTERN:name} syntax)
Grok includes 25+ built-in patterns (IP, WORD, NUMBER, TIMESTAMP_ISO8601,
LOGLEVEL, etc). Both UDFs are registered automatically in SqlTransform.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
New `logfwd-bench` crate with criterion benchmarks covering the full pipeline: scanner (all fields + pushdown), CRI parse/reassemble, DataFusion transforms (passthrough, filter, projection, regexp_extract, grok), zstd compression, output sinks, and end-to-end pipelines. Nightly GitHub Actions workflow runs benchmarks on master, parses results into a markdown table, and posts as a GitHub issue (closing the previous one to avoid clutter). Also fixes clippy warnings in UDF code (Default impls, collapsible ifs). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Criterion doesn't support --output-format bencher. Parse its native format instead (bench name on own line, followed by time/thrpt lines). Also capture stderr since criterion writes there. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
f4d5f5a to
f5b7af3
Compare
3 tasks
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--output-format bencher— that's a libtest flagVerified locally
Parser correctly produces markdown table from criterion output.
🤖 Generated with Claude Code