Fixes for MinGW cross compilation on Linux to generate Windows binaries (Part 2) - #1501
Merged
Conversation
- Further code improvements in Findlibusb.cmake Note: POSIX-Sockets conflict betweewn WIN32 and UNIX in remote.c
- Further code improvements in Findlibusb.cmake Note: POSIX-Sockets conflict betweewn WIN32 and UNIX in remote.c
- Updated and activated CI-Test for MinGW cross compiling - Fixes in win32_socket - Included cmake Threads-Module - Moved <getopt.h> include in st-server.c (temporary)
Signed-off-by: James Walmsley <james@fullfat-fs.co.uk>
Signed-off-by: James Walmsley <james@fullfat-fs.co.uk>
Signed-off-by: James Walmsley <james@fullfat-fs.co.uk>
…n_binaries # Conflicts: # src/st-server/server.c # src/st-util/semihosting.c
- Restore whitequark's copyright notice to gdb-server.c/gdb-remote.c - update notice in st-server Signed-off-by: James Walmsley <james@fullfat-fs.co.uk>
- Unified header declaration scheme - Corrected cmake parametres - Clean-up for cmake file structure - Clarified naming for Windows compile script
- Unified header declaration scheme - Corrected cmake parametres - Clean-up for cmake file structure - Clarified naming for Windows compile script
Resolved merge conflicts via command line.
Member
Author
|
@jameswalmsley: Technically it doesn't look too bad though... If there are no further issues, I'd suggest to merge this PR first, without closing the linked issues and continue with a third PR. Otherwise it will become very difficult to review the changes. |
Nightwalker-87
force-pushed
the
fix/win_binaries
branch
from
July 10, 2026 22:52
8be14cf to
4583f26
Compare
Nightwalker-87
force-pushed
the
fix/win_binaries
branch
from
July 10, 2026 22:57
4583f26 to
492d761
Compare
- Restructured dependency checks for cmake - Corrected pkg name in compiling instructions - Moved backend documentation to /doc
- Moved general header includes to header files where they belong (no changes to includes) - st-trace: #defines and typedefs go to header file - Centralise win32_socket.h include in CMakeLists.txt and leave it to cmake. This should not be done individually in the source or header files, as it is dependent on the build target. - Commented sections in unistd.h (temporary)
Member
Author
|
I’ll wait here as I know reviewing takes the time it needs. |
jameswalmsley
approved these changes
Jul 13, 2026
jameswalmsley
left a comment
Collaborator
There was a problem hiding this comment.
I'm going to approve this so you can land it, and we have a base for the next PRs.
- Removed duplicated win32_socket.h includes - Improved Windows-specific cmake config - Corrected comments in Findlibusb.cmake
This was
linked to
issues
Jul 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a subsequent PR to #1497.