Skip to content

Conversation

@peternewman
Copy link

Add a spelling checker and fix the results it found. Also test on Mac (currently broken). Upstreaming some fixes originally in arduino-libraries/ArduinoModbus#12

peternewman added a commit to peternewman/ArduinoModbus that referenced this pull request Aug 30, 2019
@peternewman
Copy link
Author

The Mac tests are failing due to this error in the user client:

[00][2E][00][00][00][06][FF][03][01][73][00][01]
Waiting for a confirmation...
<00><2E>Bytes flushed (9)
2/2 Adapted byte timeout (7ms > 5ms): 
Line 634: assertion error for 'rc == 1': 

Copy link
Owner

@stephane stephane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your script to add a spell check to Travis CI but I don't want to maintain a so complex script and Travis CI .org should be shut down in a few weeks (months I don't know).

I extracted the useful typo fixes from your PR.

@stephane stephane closed this May 10, 2021
@peternewman
Copy link
Author

Thank you for your script to add a spell check to Travis CI but I don't want to maintain a so complex script

Fair enough. It did add lots of other things including a Mac build, but maybe that's more hassle than it's worth.

I've opened #586 which is a vastly simplified (but also more functional and improved) version of spell checking via GitHub actions instead (and it's found another new typo).

and Travis CI .org should be shut down in a few weeks (months I don't know).

They've been threatening that for at least five months now I think!

I extracted the useful typo fixes from your PR.

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants