-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Travis improvements #492
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Travis improvements #492
Conversation
Originally done in arduino-libraries/ArduinoModbus#12
Pushed upstream instead in stephane/libmodbus#492
|
The Mac tests are failing due to this error in the user client: |
stephane
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your script to add a spell check to Travis CI but I don't want to maintain a so complex script and Travis CI .org should be shut down in a few weeks (months I don't know).
I extracted the useful typo fixes from your PR.
Fair enough. It did add lots of other things including a Mac build, but maybe that's more hassle than it's worth. I've opened #586 which is a vastly simplified (but also more functional and improved) version of spell checking via GitHub actions instead (and it's found another new typo).
They've been threatening that for at least five months now I think!
Thanks |
Add a spelling checker and fix the results it found. Also test on Mac (currently broken). Upstreaming some fixes originally in arduino-libraries/ArduinoModbus#12