fix: add security guardrails and cleanup lint warnings#96
Open
Misaka477 wants to merge 1 commit into
Open
Conversation
… and cleanup lint warnings
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Three defense-in-depth security improvements plus lint warning cleanup.
Changes
Security Guardrails
Shell command blocklist: added
validateShellCommand()that intercepts system-destructive patterns before they reach the shell.Workspace path boundary check:
resolveWorkspacePath()now verifies that resolved paths stay within the workspace root.ReDoS protection:
jsGrep()validates regex patterns for nested quantifiers before compiling.Lint Cleanup
Verification
tsc --noEmit✅pnpm lint✅ (0 errors, 0 warnings)pnpm test✅ (1474 passed, 8 skipped)pnpm dep-graph-check✅Closes [bug] Shell 注入风险（纵深防御缺失） #88, Closes [bug] 路径穿越（绝对路径绕过 workspace 边界） #89, Closes [bug] ReDoS 风险（正则表达式拒绝服务） #90