Fix preferences sidebar clipping and window sizing on macOS Tahoe#580
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: afc2c59330
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| # Ensure Swift >= 5.5 (required for --arch flag in swift build) | ||
| ensure_swift_version() { | ||
| local swift_ver | ||
| swift_ver=$(swift --version 2>&1 | grep -oE '[0-9]+\.[0-9]+(\.[0-9]+)?' | head -1) |
There was a problem hiding this comment.
With set -euo pipefail enabled, swift_ver=$(swift --version ... | grep ... | head -1) aborts the script immediately if swift is not on PATH, so the intended Xcode fallback (xcrun --find swift) never runs. This makes compile_and_run.sh fail in environments where only xcrun swift is available (for example, sanitized CI/login shells), even though the script now claims to support that fallback path.
Useful? React with 👍 / 👎.
The Providers tab sidebar was clipping provider names, icons, and reorder handles on the left edge due to .listStyle(.sidebar) imposing internal leading insets that push content beyond the 240px frame on macOS Tahoe. - Replace List with ScrollView+VStack for full control over sidebar layout - Add direct NSWindow.setFrame resizing since SwiftUI's .windowResizability(.contentSize) doesn't propagate frame changes - Add PreferencesTab.title and CaseIterable to eliminate hardcoded tab title strings in the window finder - Use system selectedContentBackgroundColor for sidebar selection highlight - Add ensure_swift_version() to compile_and_run.sh for Xcode toolchain fallback Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
5cab4ca to
3ac6301
Compare
Summary
.listStyle(.sidebar)internal insets pushed content beyond the 240px frame, hiding provider names, icons, and reorder handlesListwithScrollView+VStackfor full control over sidebar layout without system-imposed insetsNSWindow.setFrameresizing since SwiftUI's.windowResizability(.contentSize)doesn't propagate frame changes on TahoePreferencesTab.titleandCaseIterableto derive window-finder tab titles from the enum instead of hardcoded stringsselectedContentBackgroundColorfor sidebar selection highlightensure_swift_version()tocompile_and_run.shfor Xcode toolchain fallbackTest plan
🤖 Generated with Claude Code