Rewrite dictionary.py so it doesn't make grep explode#85
Merged
theoreticalbts merged 1 commit intomasterfrom Oct 30, 2017
Merged
Rewrite dictionary.py so it doesn't make grep explode#85theoreticalbts merged 1 commit intomasterfrom
theoreticalbts merged 1 commit intomasterfrom
Conversation
When grepping around the codebase, often a result will be found in dictionary.py and then it attempts to display a 300kb long line, which makes it hard to tell whether there are relevant results before/after. This patch refactors dictionary.py to put each word on its own line, and then replaces the resulting newlines with commas to retain compatibility.
Contributor
|
great minds think alike, thanks!!! |
goldibex
approved these changes
Oct 30, 2017
Dont-Copy-That-Floppy
pushed a commit
to Dont-Copy-That-Floppy/steem-python
that referenced
this pull request
Feb 23, 2025
…t-line Rewrite dictionary.py so it doesn't make grep explode
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When grepping around the codebase, often a result will be found in
dictionary.pyand then it attempts to display a 300kb long line, which makes it hard to tell whether there are relevant results before/after.This patch refactors
dictionary.pyto put each word on its own line, and then replaces the resulting newlines with commas to retain compatibility.You can test the validity of the patch by making a small program called
testwords.py:Since running
./testwords.py | sha256sumbefore and after this patch results in the same value off997b67f88f8928126cb73bc927c23ed830fccb62adba6b0d871804952011a01we can be sure the two versions are equivalent.