Update for loop to infinity in http_client.py#80
Merged
john-g-g merged 1 commit intosteemit:masterfrom Nov 20, 2017
Merged
Conversation
The elif-statement in its original form would never be executed, so the exception would never be raised. This could potentially lead to an infinite loop.
aditya-ramabadran
approved these changes
Oct 18, 2017
Contributor
aditya-ramabadran
left a comment
There was a problem hiding this comment.
You're right, in the previous state, the elif statement wouldn't be executed ever. This means the e would never be raised. It looks like your changes work.
john-g-g
approved these changes
Nov 20, 2017
Contributor
john-g-g
left a comment
There was a problem hiding this comment.
Thank your for your contribution!
Dont-Copy-That-Floppy
pushed a commit
to Dont-Copy-That-Floppy/steem-python
that referenced
this pull request
Feb 23, 2025
Update for loop to infinity in http_client.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The elif-statement in its original form would never be executed, so the exception would never be raised. This could potentially lead to an infinite loop.