-
-
Notifications
You must be signed in to change notification settings - Fork 1k
feat: add blas/ext/base/ndarray/sfill
#9094
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
Coverage Report
The above coverage report was generated for the changes in this PR. |
|
Thanks @kgryte. I have applied all the requested changes. The review really gave me a much clearer understanding of the architectural patterns and the 'why' behind them. I have updated this PR and propagated the same standards to all my related PRs (eg : sapx, gapx and etc.) as well. Ready for review. P.S. I am aware of RFC #8647 regarding string interpolation. For now, I stuck to the dsorthp pattern (concatenation), but let me know if you would prefer I migrate these benchmarks to use @stdlib/string/format in this PR and related ones. |
|
@Amansingh0807 I suggest going ahead and using |
|
Acknowledged, thanks @kgryte. I’ve migrated the benchmarks to use |
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
Resolves None.
Description
This pull request:
blas/ext/base/ndarray/sfillRelated Issues
This pull request has the following related issues:
Questions
No.
Other
No.
Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
@stdlib-js/reviewers