Skip to content

properly take into account r_eff when deciding tail length#402

Merged
avehtari merged 3 commits intostan-dev:masterfrom
n-kall:tail-length-fix
Mar 31, 2025
Merged

properly take into account r_eff when deciding tail length#402
avehtari merged 3 commits intostan-dev:masterfrom
n-kall:tail-length-fix

Conversation

@n-kall
Copy link
Copy Markdown
Collaborator

@n-kall n-kall commented Mar 28, 2025

Summary

This should fix #396

@avehtari would you check that this is correct? There's also the question of whether to use floor (like the paper) or ceiling (like we have been using).

Copyright and Licensing

By submitting this pull request, the copyright holder is agreeing to
license the submitted work under the following licenses:

@avehtari
Copy link
Copy Markdown
Member

Let's switch to floor as we can't change it in the paper

@n-kall
Copy link
Copy Markdown
Collaborator Author

n-kall commented Mar 31, 2025

Switched to floor, seems to work fine. Failing checks are unrelated. I think this is ready

@paul-buerkner
Copy link
Copy Markdown
Collaborator

Aki, can you approve and merge? I am happy to merge but would like your approval first.

@avehtari avehtari merged commit f17844f into stan-dev:master Mar 31, 2025
7 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ps_tail_length can result in tail length longer than ndraws

3 participants