properly take into account r_eff when deciding tail length#402
Merged
avehtari merged 3 commits intostan-dev:masterfrom Mar 31, 2025
Merged
properly take into account r_eff when deciding tail length#402avehtari merged 3 commits intostan-dev:masterfrom
avehtari merged 3 commits intostan-dev:masterfrom
Conversation
avehtari
reviewed
Mar 28, 2025
Member
|
Let's switch to floor as we can't change it in the paper |
n-kall
commented
Mar 31, 2025
Collaborator
Author
|
Switched to floor, seems to work fine. Failing checks are unrelated. I think this is ready |
Collaborator
|
Aki, can you approve and merge? I am happy to merge but would like your approval first. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This should fix #396
@avehtari would you check that this is correct? There's also the question of whether to use floor (like the paper) or ceiling (like we have been using).
Copyright and Licensing
By submitting this pull request, the copyright holder is agreeing to
license the submitted work under the following licenses: