chore: add "Bearer" prefix to authorization headers [ENG-6467]#91
chore: add "Bearer" prefix to authorization headers [ENG-6467]#91albertodonato merged 2 commits intomainfrom
Conversation
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
| token = get_token() | ||
|
|
||
| url = f"https://{context.config.cubejs}/cubejs-api/v1/load" | ||
| url = f"{context.config.cubejs}/cubejs-api/v1/load" |
There was a problem hiding this comment.
URL scheme removal may break manual configurations
Medium Severity
The https:// prefix was removed from URL construction, but this change isn't mentioned in the PR description. Users who manually configured cubejs with just a hostname (e.g., cubejs.example.com) instead of a full URL will now get invalid URLs like cubejs.example.com/cubejs-api/... without a scheme. While auto-configure already includes https:// in the config, manual configurations via the --cubejs option don't enforce a scheme.
Additional Locations (1)
[ENG-6467](https://stacklet.atlassian.net/browse/ENG-6467) ### what add the "Bearer" type prefix for authorization headers using the token ### why it's more standard ### testing tested against sandbox ### docs n/a
fwereade
left a comment
There was a problem hiding this comment.
LGTM, thanks. (A little disappointing this doesn't break any tests)
9d01934 to
93293f5
Compare
ENG-6467
what
add the "Bearer" type prefix for authorization headers using the token
why
it's more standard
testing
tested against sandbox
docs
n/a