chore: rework global context and CLI setup#89
Closed
albertodonato wants to merge 1 commit intomainfrom
Closed
Conversation
1abb794 to
ac25cb0
Compare
[ENG-6324](https://stacklet.atlassian.net/browse/ENG-6324) ### what - support using API keys in place of tokens (via `STACKLET_API_KEY` env var) - rework StackletContext and StackletConfig and add StackletCredentials - cleanup click-related setup to use the StackletContext for common data - remove `click_group_entry` which was defined and called for each group in addition to handlers (so multiple times for a single CLI call) ### why - provide support for API keys - make the CLI setup more predictable by accessing all configured details via StackletContext, rather than sticking entries in a plain dict. ### testing local testing, updated tests ### docs n/a
ac25cb0 to
475743d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
what
click_group_entrywhich was defined and called for each group inaddition to handlers (so multiple times for a single CLI call)
why
make the CLI setup more predictable by accessing all configured details via StackletContext, rather than sticking entries in a plain dict.
testing
local testing, updated tests
docs
n/a