-
Notifications
You must be signed in to change notification settings - Fork 1
[Merged by Bors] - Implement demo command #66
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one typo. Works great!

Just ran in the superset timeout, but nothing we can do about that here.
malte@mdesktop ~/d/w/stackablectl (demos) [2]> target/debug/stackablectl demo list
[WARN ] Failed to parse demo list from https://github.com/stackabletech/stackablectl/main/demos/demos-v1.yaml: missing field `demos` at line 1 column 4
DEMO STACKABLE STACK DESCRIPTION
malte@mdesktop ~/d/w/stackablectl (demos)> target/debug/stackablectl demo describe trino-taxi-data
[WARN ] Failed to parse demo list from https://github.com/stackabletech/stackablectl/main/demos/demos-v1.yaml: missing field `demos` at line 1 column 4
[ERROR] Demo trino-taxi-data not found. Use `stackablectl demo list` to list the available demos.
malte@mdesktop ~/d/w/stackablectl (demos) [255]>
The list and describe do not work for me?
|
As this PR is not merged you have to specify the additional demos file like |
maltesander
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
|
@maltesander could you please also review the new docs? |
maltesander
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like it but im not sure about the detail of the description. It feels a lot of it could e.g. be in the superset docs (the story about how many passengers, invalid records, views etc.)
Co-authored-by: Malte Sander <[email protected]>
Co-authored-by: Malte Sander <[email protected]>
Co-authored-by: Malte Sander <[email protected]>
Co-authored-by: Malte Sander <[email protected]>
|
I moved the documentation to a separate (optional) field so it's machine-readable. I don't think we want to print the docs link when listing the demos, what do you think? |
|
Thanks @maltesander, comments should be addressed. |
Ok yeah related to the demo data that makes sense then for me. One more thing: |
|
Oh noes, missed that. Added now |
maltesander
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! LGTM.
|
Thanks a lot for your very fast review! |
|
bors r+ |
## Description Proudly presenting the first Stackable demo of the world 🥳 Works best with stackabletech/superset-operator#247. If you don't increasing the Superset timeout the charts may time out. In that case simply refresh them **one by one while there is no other query running on Trino (check via Trino webui)**.   To invoke run (from feature branch) ``` sbernauer@sbernauer:~/stackabletech/stackablectl$ cargo r -- --additional-demos-file demos/demos-v1.yaml demo install trino-taxi-data Finished dev [unoptimized + debuginfo] target(s) in 0.06s Running `target/debug/stackablectl --additional-demos-file demos/demos-v1.yaml demo install trino-taxi-data` [INFO ] Installing demo trino-taxi-data [WARN ] Failed to parse demo list from https://github.com/stackabletech/stackablectl/main/demos/demos-v1.yaml: missing field `demos` at line 1 column 4 [INFO ] Installing stack trino-superset-s3 [INFO ] Installing release 22.06 [INFO ] Installing airflow operator in version 0.4.0 [INFO ] The release airflow-operator in version 0.4.0 is already installed, not installing it [INFO ] Installing commons operator in version 0.2.0 [INFO ] The release commons-operator in version 0.2.0 is already installed, not installing it [INFO ] Installing druid operator in version 0.6.0 [INFO ] The release druid-operator in version 0.6.0 is already installed, not installing it [INFO ] Installing hbase operator in version 0.3.0 [INFO ] The release hbase-operator in version 0.3.0 is already installed, not installing it [INFO ] Installing hdfs operator in version 0.4.0 [INFO ] The release hdfs-operator in version 0.4.0 is already installed, not installing it [INFO ] Installing hive operator in version 0.6.0 [INFO ] The release hive-operator in version 0.6.0 is already installed, not installing it [INFO ] Installing kafka operator in version 0.6.0 [INFO ] The release kafka-operator in version 0.6.0 is already installed, not installing it [INFO ] Installing nifi operator in version 0.6.0 [INFO ] The release nifi-operator in version 0.6.0 is already installed, not installing it [INFO ] Installing opa operator in version 0.9.0 [INFO ] The release opa-operator in version 0.9.0 is already installed, not installing it [INFO ] Installing secret operator in version 0.5.0 [INFO ] The release secret-operator in version 0.5.0 is already installed, not installing it [INFO ] Installing spark-k8s operator in version 0.3.0 [INFO ] The release spark-k8s-operator in version 0.3.0 is already installed, not installing it [INFO ] Installing superset operator in version 0.5.0 [INFO ] The release superset-operator in version 0.5.0 is already installed, not installing it [INFO ] Installing trino operator in version 0.4.0 [INFO ] The release trino-operator in version 0.4.0 is already installed, not installing it [INFO ] Installing zookeeper operator in version 0.10.0 [INFO ] The release zookeeper-operator in version 0.10.0 is already installed, not installing it [INFO ] Installing components of stack trino-superset-s3 [INFO ] The release minio-trino in version 4.0.5 is already installed, not installing it [INFO ] The release postgresql-hive in version 10.16.2 is already installed, not installing it [INFO ] The release postgresql-superset in version 11.0.0 is already installed, not installing it [INFO ] Installed stack trino-superset-s3 [INFO ] Installing components of demo trino-taxi-data [INFO ] Installed demo trino-taxi-data. Use "stackablectl services list" to list the installed services sbernauer@sbernauer:~/stackabletech/stackablectl$ stackablectl services list PRODUCT NAME NAMESPACE ENDPOINTS EXTRA INFOS hive hive default hive 172.18.0.4:32658 metrics 172.18.0.4:30745 opa opa default http http://172.18.0.2:31324 superset superset default external-superset http://172.18.0.2:32716 Admin user: admin, password: admin trino trino default coordinator-http http://172.18.0.5:32128 coordinator-metrics 172.18.0.5:31199 coordinator-https https://172.18.0.5:32721 minio minio-trino default http http://172.18.0.4:31026 Third party service console-http http://172.18.0.4:30354 Admin user: root, password: rootroot ```
|
Pull request successfully merged into main. Build succeeded: |
Description
Proudly presenting the first Stackable demo of the world 🥳
Works best with stackabletech/superset-operator#247.
If you don't increasing the Superset timeout the charts may time out. In that case simply refresh them one by one while there is no other query running on Trino (check via Trino webui).
To invoke run (from feature branch)
Review Checklist
Once the review is done, comment
bors r+(orbors merge) to merge. Further information