Skip to content
This repository was archived by the owner on Feb 16, 2024. It is now read-only.

[Merged by Bors] - Print CLI tables using comfy-table #176

Closed
sbernauer wants to merge 5 commits into from
Closed

[Merged by Bors] - Print CLI tables using comfy-table #176

sbernauer wants to merge 5 commits into from

Conversation

@sbernauer
Copy link
Member

@sbernauer sbernauer commented Nov 25, 2022

Description

For #162

Review Checklist

  • Code contains useful comments
  • (Integration-)Test cases added (or not applicable)
  • Documentation added (or not applicable)
  • Changelog updated (or not applicable)
  • Cargo.toml only contains references to git tags (not specific commits or branches)

Once the review is done, comment bors r+ (or bors merge) to merge. Further information

@sbernauer sbernauer requested review from a team and fhennig November 25, 2022 12:58
@nightkr
Copy link
Contributor

nightkr commented Nov 25, 2022

Looks like we now have different table formats for different commands?

Screenshot_20221125_160320

@sbernauer
Copy link
Member Author

sbernauer commented Nov 28, 2022

Good catch, that was a leftover! Used ack 'use comfy_table::' -C 5 src to check there are no others

@sbernauer sbernauer requested review from a team and removed request for a team December 2, 2022 08:39
@sbernauer sbernauer self-assigned this Dec 2, 2022
maltesander
maltesander reviewed Dec 2, 2022
View reviewed changes
Copy link
Member

@maltesander maltesander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The operator list command still uses simple prints. We wan to have it there as well for consistency? I know we talked about this but cannot really remember the outcome.

@sbernauer
Copy link
Member Author

sbernauer commented Dec 2, 2022

Good catch, fixed

@sbernauer sbernauer requested a review from maltesander December 2, 2022 14:51
maltesander
maltesander approved these changes Dec 2, 2022
View reviewed changes
Copy link
Member

@maltesander maltesander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@sbernauer
Copy link
Member Author

sbernauer commented Dec 2, 2022

bors r+

bors bot pushed a commit that referenced this pull request Dec 2, 2022
@sbernauer
Print CLI tables using comfy-table (#176)
4cd1149 
## Description

For #162
@bors
Copy link

bors bot commented Dec 2, 2022

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Print CLI tables using comfy-table [Merged by Bors] - Print CLI tables using comfy-table Dec 2, 2022
@bors bors bot closed this Dec 2, 2022
@bors bors bot deleted the comfy-table branch December 2, 2022 16:05
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@fhennig fhennig Awaiting requested review from fhennig

1 more reviewer

@maltesander maltesander maltesander approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@sbernauer sbernauer

Labels

release/2023-01

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@sbernauer @nightkr @maltesander @lfrancke