-
-
Notifications
You must be signed in to change notification settings - Fork 3
feat: Warn when stack/demo is larger than cluster #94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Techassi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some suggestions. Nice feature!
|
Some suggested improvements: feat/check-demo-resoures...feat/check-demo-resoures-techassi |
|
@Techassi did pull in your commit, but also push two other ones. Would be great if you could have a look! |
rust/stackable-cockpit/src/platform/cluster/resource_request.rs
Outdated
Show resolved
Hide resolved
Techassi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. However we need to make sure that all pre-commits are run. Either manually like pre-commit run --all-files or by installing them permanently.
|
This feels a bit misleading, since it goes by a very optimistic view of scheduling (one node with no CPU but 1TiB RAM and another node with a 128-core EPYC and no RAM still wouldn't be able to schedule anything useful together). I can see the value in giving early feedback, but I also wonder if it'd make more sense to focus on surfacing the actual scheduling errors in more discoverable ways. |
|
@Techassi thanks for review! |
|
Yeah I don't want to block this PR on that. |
|
Alright, but it's a good and valid point! |
Description
Related to stackabletech/stackablectl#268
Definition of Done Checklist
Once the review is done, comment
bors r+(orbors merge) to merge. Further information