Skip to content

Conversation

@NickLarsenNZ
Copy link
Member

Description

Resolves #142

  • Rename old plain output option to table
  • Ceate a new output option for plain which removes border characters and disables dynamic table arrangement.
    • There is an issue where there are multiple newlines between rows
    • There should be further discussion about what plain output should look like. This PR felt like a good-enough compromise between existing code and avoiding broken hyperlinks
    • We might need to use force_no_tty() when the output is plain, but I will look at that in a future PR where I add output options for cache list.

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes
# Author
- [ ] Changes are OpenShift compatible
- [ ] CRD changes approved
- [ ] Helm chart can be installed and deployed operator works
- [ ] Integration tests passed (for non trivial changes)
# Reviewer
- [ ] Code contains useful comments
- [ ] (Integration-)Test cases added
- [ ] Documentation added or updated
- [ ] Changelog updated
- [ ] Cargo.toml only contains references to git tags (not specific commits or branches)
# Acceptance
- [ ] Feature Tracker has been updated
- [ ] Proper release label has been added

Once the review is done, comment bors r+ (or bors merge) to merge. Further information

@NickLarsenNZ NickLarsenNZ marked this pull request as draft December 15, 2023 12:32
@NickLarsenNZ NickLarsenNZ force-pushed the feat/plain-output-support branch from 6650eff to 569d1d7 Compare December 15, 2023 12:50
@NickLarsenNZ NickLarsenNZ marked this pull request as ready for review December 15, 2023 12:53
Copy link
Member

@Techassi Techassi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Exact styling of the new plain output mode can be discussed later. For now, a table without borders and line-wraps seems sufficient.

@NickLarsenNZ NickLarsenNZ added this pull request to the merge queue Dec 15, 2023
Merged via the queue into main with commit 07f5898 Dec 15, 2023
@NickLarsenNZ NickLarsenNZ deleted the feat/plain-output-support branch December 15, 2023 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

feat: Implement plain and table output

3 participants