Skip to content
This repository was archived by the owner on Jul 20, 2022. It is now read-only.

Print startup diagnostic information using the built crate#118

Merged
lfrancke merged 5 commits intomainfrom
built_info
Aug 19, 2021
Merged

Print startup diagnostic information using the built crate#118
lfrancke merged 5 commits intomainfrom
built_info

Conversation

@lfrancke
Copy link
Copy Markdown
Member

@lfrancke lfrancke commented Aug 13, 2021

This relies on stackabletech/operator-rs#192
It can be reviewed already but should be changed to use the main branch of operator-rs before merging.

This is related to stackabletech/issues#19

Copy link
Copy Markdown
Member

@soenkeliebau soenkeliebau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ran this and all looks good to me.
Once we merged stackabletech/operator-rs#192 and updated the cargo.toml files in here I think we are good to go.

@lfrancke lfrancke marked this pull request as ready for review August 16, 2021 14:59
@lfrancke lfrancke requested a review from a team August 16, 2021 15:00
Copy link
Copy Markdown
Member

@soenkeliebau soenkeliebau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lfrancke lfrancke merged commit 88501ed into main Aug 19, 2021
@lfrancke lfrancke deleted the built_info branch August 19, 2021 09:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants