Closed
Conversation
4 tasks
Co-authored-by: Sebastian Bernauer <sebastian.bernauer@stackable.de>
Co-authored-by: Sebastian Bernauer <sebastian.bernauer@stackable.de>
sbernauer
reviewed
Jan 19, 2023
Member
sbernauer
left a comment
There was a problem hiding this comment.
Review finished. I would like to try it out in the meantime
Co-authored-by: Sebastian Bernauer <sebastian.bernauer@stackable.de>
Co-authored-by: Sebastian Bernauer <sebastian.bernauer@stackable.de>
Co-authored-by: Sebastian Bernauer <sebastian.bernauer@stackable.de>
Co-authored-by: Sebastian Bernauer <sebastian.bernauer@stackable.de>
Co-authored-by: Sebastian Bernauer <sebastian.bernauer@stackable.de>
Co-authored-by: Sebastian Bernauer <sebastian.bernauer@stackable.de>
Closed
5 tasks
3 tasks
bors Bot
pushed a commit
to stackabletech/stackablectl
that referenced
this pull request
Jan 19, 2023
## Description I suggest reviewing commits separately Currently with stackabletech/spark-k8s-operator#187 it produces. We should probably adopt the exposed services ``` ┌──────────────────────┬───────────────┬──────────────────────────────┬───────────────────────────────────────────┬──────┐ │ Product ┆ Name ┆ Namespace ┆ Endpoints ┆ Info │ ╞══════════════════════╪═══════════════╪══════════════════════════════╪═══════════════════════════════════════════╪══════╡ │ spark-history-server ┆ spark-history ┆ kuttl-test-credible-crayfish ┆ node-http http://172.18.0.4:32525 ┆ │ │ ┆ ┆ ┆ node-cleaner-http http://172.18.0.4:32589 ┆ │ └──────────────────────┴───────────────┴──────────────────────────────┴───────────────────────────────────────────┴──────┘ ``` ## Review Checklist - [ ] Code contains useful comments - [ ] (Integration-)Test cases added (or not applicable) - [ ] Documentation added (or not applicable) - [ ] Changelog updated (or not applicable) - [ ] Cargo.toml only contains references to git tags (not specific commits or branches) Once the review is done, comment `bors r+` (or `bors merge`) to merge. [Further information](https://bors.tech/documentation/getting-started/#reviewing-pull-requests)
Member
Author
|
bors merge |
bors Bot
pushed a commit
that referenced
this pull request
Jan 20, 2023
Fixes #124 #162 Jenkins: [Azure:heavy_check_mark:](https://ci.stackable.tech/view/02%20Operator%20Tests%20(custom)/job/spark-k8s-operator-it-custom/60/) Co-authored-by: Andrew Kenworthy <andrew.kenworthy@stackable.de>
|
Pull request successfully merged into main. Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #124 #162
Jenkins: Azure:heavy_check_mark: