[Merged by Bors] - Helm chart#27
Closed
nightkr wants to merge 9 commits into
Closed
Conversation
…or into feature/helm
maltesander
approved these changes
Jan 27, 2022
Member
maltesander
left a comment
There was a problem hiding this comment.
Just a question and minor labeling (at least for readme, not in the generated stuff).
LGTM otherwise.
| @@ -0,0 +1,33 @@ | |||
| # Helm Chart for Stackable Operator for Stackable Secret Operator | |||
|
|
|||
| This Helm Chart can be used to install Custom Resource Definitions and the Operator for Stackable Secret Operator provided by Stackable. | |||
Member
There was a problem hiding this comment.
Ok i dont think that naming makes sense, but its consistent :D
This Helm Chart can be used to install Custom Resource Definitions and the Secret Operator provided by Stackable.
Contributor
Author
|
bors r+ |
bors Bot
pushed a commit
that referenced
this pull request
Jan 27, 2022
Fixes #25 For now I applied the templating manually (from stackabletech/operator-templating#55, commit stackabletech/operator-templating@4fd238d) and adapted it for secret-operator by hand. These changes are contained in 878c4a6, and basically mean: - Deploying as a `DaemonSet` rather than a `Deployment` - Adding CSI sidecar containers - Running as root (at some point we might be able to get away with "just" adding a bunch of capabilities, but secret-operator will probably always require relatively elevated privileges) - Disabling product-config - Extracting the CRD by running `cargo run crd` rather than reading the file that `build.rs` creates (Nix doesn't allow access to files outside of the source tree) - Adapting to the `ClusterRole` rules that secret-operator requires Currently this branch contains both the `Dockerfile`- and Nix-based workflows for building the operator, but we should probably pick one at some point. Co-authored-by: Stacky McStackface <stackable-bot@users.noreply.github.com>
Contributor
|
Pull request successfully merged into main. Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #25
For now I applied the templating manually (from stackabletech/operator-templating#55, commit stackabletech/operator-templating@4fd238d) and adapted it for secret-operator by hand.
These changes are contained in 878c4a6, and basically mean:
DaemonSetrather than aDeploymentcargo run crdrather than reading the file thatbuild.rscreates (Nix doesn't allow access to files outside of the source tree)ClusterRolerules that secret-operator requiresCurrently this branch contains both the
Dockerfile- and Nix-based workflows for building the operator, but we should probably pick one at some point.