Skip to content

Conversation

@sbernauer
Copy link
Member

@sbernauer sbernauer commented Apr 23, 2024

Description

Part of #422

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes
# Author
- [x] Changes are OpenShift compatible
- [ ] CRD changes approved
- [ ] CRD documentation for all fields, following the [style guide](https://docs.stackable.tech/home/nightly/contributor/docs-style-guide).
- [x] Helm chart can be installed and deployed operator works
- [x] Integration tests passed (for non trivial changes) https://ci.stackable.tech/view/02%20Operator%20Tests%20(custom)/job/opa-operator-it-custom/96/
- [x] Changes need to be "offline" compatible
# Reviewer
- [ ] Code contains useful comments
- [ ] Code contains useful logging statements
- [ ] (Integration-)Test cases added
- [ ] Documentation added or updated. Follows the [style guide](https://docs.stackable.tech/home/nightly/contributor/docs-style-guide).
- [ ] Changelog updated
- [ ] Cargo.toml only contains references to git tags (not specific commits or branches)
# Acceptance
- [ ] Feature Tracker has been updated
- [ ] Proper release label has been added
- [ ] [Roadmap](https://github.com/orgs/stackabletech/projects/25/views/1) has been updated

@xeniape xeniape force-pushed the decision-logging-in-crd branch from b8d1c74 to 9551693 Compare May 10, 2024 13:25
@xeniape xeniape linked an issue May 27, 2024 that may be closed by this pull request
2 tasks
@xeniape xeniape marked this pull request as ready for review May 27, 2024 09:00
@maltesander maltesander mentioned this pull request May 27, 2024
@Techassi Techassi self-requested a review May 27, 2024 10:02
Copy link
Member

@Techassi Techassi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Partial review, a few minor changes.

@xeniape xeniape requested a review from Techassi May 29, 2024 15:20
@xeniape xeniape requested a review from Techassi June 3, 2024 12:58
@xeniape xeniape added this pull request to the merge queue Jun 4, 2024
Merged via the queue into main with commit e12d2d4 Jun 4, 2024
@xeniape xeniape deleted the decision-logging-in-crd branch June 4, 2024 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

Decision logging currently disabled

4 participants