Conversation
Member
|
Should we close #175 to avoid confusion? |
Contributor
Author
|
Sounds good yeah. |
Contributor
Author
|
Watching is blocked on stackabletech/listener-operator#138, but I wouldn't block on that since most expected changes here would be during startup/scale events (which would ping the operator anyway). We'd still want to pull that out into an issue here and fix eventually, obviously. |
Contributor
Author
|
The current testing approach is blocked on kudobuilder/kuttl#322. Are we okay to punt on testing external access as long as the internal access tests still function? |
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…r into feat/listener
nightkr
commented
Jan 16, 2024
siegfriedweber
requested changes
Jan 19, 2024
Co-authored-by: Siegfried Weber <mail@siegfriedweber.net>
siegfriedweber
approved these changes
Jan 26, 2024
sbernauer
added a commit
that referenced
this pull request
Feb 5, 2024
15 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #174, supersedes #175.
Definition of Done Checklist