Skip to content

feat: Support graceful shutdown #402

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sbernauer merged 26 commits into from
Nov 2, 2023
Merged

feat: Support graceful shutdown #402

sbernauer merged 26 commits into from
Nov 2, 2023

Conversation

@sbernauer
Copy link
Member

@sbernauer sbernauer commented Oct 11, 2023 •
edited
Loading

Description

Part of stackabletech/issues#357
Closes #400

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes
# Author
- [x] Changes are OpenShift compatible
- [x] CRD changes approved
- [x] Helm chart can be installed and deployed operator works
- [x] Integration tests passed (for non trivial changes)
- [x] Changes need to be "offline" compatible

# Reviewer
- [x] Code contains useful comments
- [x] (Integration-)Test cases added
- [x] Documentation added or updated
- [x] Changelog updated
- [x] Cargo.toml only contains references to git tags (not specific commits or branches)

# Acceptance
- [ ] Feature Tracker has been updated
- [ ] Proper release label has been added

Techassi
Techassi requested changes Oct 19, 2023
View reviewed changes
Copy link
Member

@Techassi Techassi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor nits.

@sbernauer
Copy link
Member Author

sbernauer commented Oct 19, 2023

Please have a look at 5a27400 and stackabletech/hdfs-operator@153b2c2

@sbernauer sbernauer requested a review from Techassi October 19, 2023 13:16
Techassi
Techassi requested changes Oct 19, 2023
View reviewed changes
Copy link
Member

@Techassi Techassi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Final nit :)

@sbernauer sbernauer requested a review from Techassi October 19, 2023 13:48
@sbernauer
Copy link
Member Author

sbernauer commented Oct 19, 2023

https://ci.stackable.tech/view/02%20Operator%20Tests%20(custom)/job/hbase-operator-it-custom/107/

Techassi
Techassi previously approved these changes Oct 19, 2023
View reviewed changes
siegfriedweber
siegfriedweber previously approved these changes Oct 31, 2023
View reviewed changes
Copy link
Member

@siegfriedweber siegfriedweber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sbernauer
Copy link
Member Author

sbernauer commented Nov 2, 2023

Final test run: https://ci.stackable.tech/view/02%20Operator%20Tests%20(custom)/job/hbase-operator-it-custom/110/

@sbernauer
Copy link
Member Author

sbernauer commented Nov 2, 2023

Started https://ci.stackable.tech/job/hbase-operator-it-custom/111/

@sbernauer
Copy link
Member Author

sbernauer commented Nov 2, 2023

Tests passed 🚀

@sbernauer sbernauer added this pull request to the merge queue Nov 2, 2023
Merged via the queue into main with commit 809e3b6 Nov 2, 2023
@sbernauer sbernauer deleted the feat/graceful-shutdown branch November 2, 2023 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Techassi Techassi Techassi approved these changes

@siegfriedweber siegfriedweber siegfriedweber left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Support graceful shutdown

5 participants

@sbernauer @Techassi @siegfriedweber @Jimvin