This repository was archived by the owner on Dec 21, 2021. It is now read-only.
Crash fixed when no tag is provided for the container image#40
Merged
lfrancke merged 3 commits intostackabletech:mainfrom Jan 22, 2021
siegfriedweber:fix_crash_on_missing_reference_tag
Merged
Crash fixed when no tag is provided for the container image#40lfrancke merged 3 commits intostackabletech:mainfrom siegfriedweber:fix_crash_on_missing_reference_tag
lfrancke merged 3 commits intostackabletech:mainfrom
siegfriedweber:fix_crash_on_missing_reference_tag
Conversation
|
|
Member
|
I spoke with Lars this morning and he will try to review this PR this afternoon. |
lfrancke
suggested changes
Jan 21, 2021
Member
lfrancke
left a comment
There was a problem hiding this comment.
Only minor stuff.
This looks fabulous.
If this is your first Rust PR I'm depressed :) Good job!
lfrancke
approved these changes
Jan 22, 2021
Member
lfrancke
left a comment
There was a problem hiding this comment.
Looks good to me, thank you!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #39
When no tag is provided for the container image then the agent crashes:
With this change the pod is rejected with an according log message: