Skip to content

fix(monocle-react): Remove script src from monocle script error #50

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jaredpiedt merged 1 commit into from
Jan 23, 2026
Merged

fix(monocle-react): Remove script src from monocle script error #50

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/empty-years-stand.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@spur.us/monocle-react": patch
---

Remove script src from monocle script error
7 changes: 3 additions & 4 deletions packages/monocle-react/src/contexts/MonocleProvider.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,10 +31,9 @@ const MonocleProviderComponent: React.FC<MonocleProviderProps> = ({

const loadScript = () => {
return new Promise<void>((resolve, reject) => {
const createScriptError = (e: Event | string, scriptUrl: string) => {
const createScriptError = (e: Event | string) => {
const errorDetails = [
'Failed to load Monocle script',
`URL: ${scriptUrl}`,
];

if (e instanceof ErrorEvent && e.message) {
Expand All @@ -56,7 +55,7 @@ const MonocleProviderComponent: React.FC<MonocleProviderProps> = ({
if (!window.MCL) {
existingScript.onload = () => resolve();
existingScript.onerror = (e) =>
reject(createScriptError(e, existingScript.src));
reject(createScriptError(e));
} else {
resolve();
}
Expand All @@ -77,7 +76,7 @@ const MonocleProviderComponent: React.FC<MonocleProviderProps> = ({
resolve();
};
script.onerror = (e) => {
reject(createScriptError(e, script.src));
reject(createScriptError(e));
};
document.head.appendChild(script);
});
Expand Down