Skip to content

fix(monocle-react): Fix refresh return type in MonocleContextType #42

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jaredpiedt merged 1 commit into from
Sep 18, 2025
Merged

fix(monocle-react): Fix refresh return type in MonocleContextType #42

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/proud-rings-attend.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@spur.us/monocle-react": patch
---

Fix refresh return type in `MonocleContextType`
8 changes: 4 additions & 4 deletions packages/monocle-react/src/contexts/MonocleProvider.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,9 +9,10 @@ import React, {
import { withMaxAllowedInstancesGuard } from '../utils';
import { MonocleProviderProps } from '../types';
import { DOMAIN } from '../constants';

interface MonocleContextType {
assessment: string | undefined;
refresh: () => void;
refresh: () => Promise<void>;
isLoading: boolean;
error: Error | null;
}
Expand Down Expand Up @@ -61,10 +62,9 @@ const MonocleProviderComponent: React.FC<MonocleProviderProps> = ({
try {
setIsLoading(true);
setError(null);

if (window.MCL) {
await window.MCL.refresh();
setIsLoading(false);
} else {
throw new Error('MCL object not found on window');
}
Expand Down Expand Up @@ -108,7 +108,7 @@ const MonocleProviderComponent: React.FC<MonocleProviderProps> = ({
if (!assessment) {
initializeMCL();
}

// Cleanup function to reset callback on unmount
return () => {
if (window.MCL) {
Expand Down