fix(monocle-types,monocle-react): Fix issue where assessment wasn't set in MonocleProvider#38
Merged
jaredpiedt merged 2 commits intomainfrom Jul 2, 2025
Merged
Conversation
…et in MonocleProvider
There was a problem hiding this comment.
Pull Request Overview
This PR ensures the assessment value is properly set in MonocleProvider by updating the handler signature, wiring the new callback into window.MCL.configure, and adjusting related logic.
- Update
onAssessmenttype to accept raw string assessments - Enhance
MonocleProviderto configure MCL with the new callback and handle existing assessments - Clamp instance counts, restructure imports, and memoize context value
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| packages/types/src/index.ts | Changed onAssessment param type from MonocleAssessment to string |
| packages/monocle-react/src/utils/useMaxAllowedInstancesGuard.tsx | Prevent negative counts when unmounting instances |
| packages/monocle-react/src/types.ts | Added import React for type definitions |
| packages/monocle-react/src/contexts/MonocleProvider.tsx | Configure MCL with onAssessment, check existing assessment, add useMemo for context, update effect deps |
| .changeset/pink-friends-invite.md | Documented the signature fix and provider behavior correction |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Type of Change
Checklist
pnpm testand all tests passpnpm lintand there are no linting errors