Merged
Conversation
Owner
|
Thanks so much for this fix. As far as As far as the I'll flash this and verify then if it looks good I'll merge this today. Thanks! |
(needed if using external led)
Owner
|
Thanks! LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes sure that we can compile OpenSpool with ESPHome 2025.6.0
2025.6.0 comes with some nice updates like ESP-IDF 5.3.2 that have official support with ESP32 S3 and some speed and size-optimizations.
More info can be found here: https://esphome.io/changelog/2025.6.0.html#esphome-2025-6-0-18th-june-2025
I have tried compiling and uploading esp32-s3-devkitc-1.yaml with the updated code without any problems.
I have also added the flash_write_interval with a 3 second interval.
In eariler esphome versions the values would get saved immediatly on change. Without flash_write_interval components with
restore_value: truewould only see its values stored once ever minute. I felts 3 seconds was a good middlepoint of fast saving and not spamming the flash. Thoughts?