-
Notifications
You must be signed in to change notification settings - Fork 6.2k
Closed
Labels
status: waiting-for-triageAn issue we've not yet triagedAn issue we've not yet triagedtype: bugA general bugA general bug
Description
Describe the bug
The details provided in the spring security page to use Open Saml 5.x has issues:
https://docs.spring.io/spring-security/reference/servlet/saml2/opensaml.html
To Reproduce
Navigate to page: https://docs.spring.io/spring-security/reference/servlet/saml2/opensaml.html
- Maven details does not have proper dependency XML tag ending (XML is invalid).
- There is not artifcat with name opensaml-saml-imple
- "opensaml-saml-api" has fourth party dependency for "opensaml-core-api". So there is no need to explicitly mentioned it.
- "spring-security-saml2-service-provider" has direct dependency only with "opensaml-saml-api" and "opensaml-saml-impl"
Expected behavior
Modify maven details in the page: https://docs.spring.io/spring-security/reference/servlet/saml2/opensaml.html
<dependency>
<groupId>org.springframework.security</groupId>
<artifactId>spring-security-saml2-service-provider</artifactId>
<version>${org.spring-security-core.version}</version>
<exclusions>
<exclusion>
<groupId>org.opensaml</groupId>
<artifactId>*</artifactId>
</exclusion>
</exclusions>
</dependency>
<dependency>
<groupId>org.opensaml</groupId>
<artifactId>opensaml-saml-api</artifactId>
<version>${opensaml.version}</version>
</dependency>
<dependency>
<groupId>org.opensaml</groupId>
<artifactId>opensaml-saml-impl</artifactId>
<version>${opensaml.version}</version>
</dependency>
Metadata
Metadata
Assignees
Labels
status: waiting-for-triageAn issue we've not yet triagedAn issue we've not yet triagedtype: bugA general bugA general bug