Conversation
onobc
reviewed
May 7, 2025
onobc
left a comment
There was a problem hiding this comment.
The changes make sense to me. I will adapt what I have done in Spring Data Cassandra to fit this as well. I have a couple of comments but other than that LGTM.
Member
|
The interface resolution when generating the interface OwnerRepository extends Repository<Owner, Long> {
void save(Owner owner);
}{
"name": "save",
"signature": "public abstract void org.springframework.samples.petclinic.owner.OwnerRepository.save(org.springframework.samples.petclinic.owner.Owner)",
"fragment": {
"interface": "org.springframework.data.mongodb.repository.support.SimpleMongoRepository",
"fragment": "org.springframework.data.mongodb.repository.support.SimpleMongoRepository"
}
}, |
Member
Author
|
Yeah, I have no good idea to fix that yet. The |
christophstrobl
pushed a commit
that referenced
this pull request
May 9, 2025
christophstrobl
added a commit
that referenced
this pull request
May 9, 2025
Original Pull Request: #4964
Member
|
merged to 5.0.x |
christophstrobl
pushed a commit
that referenced
this pull request
May 15, 2025
christophstrobl
added a commit
that referenced
this pull request
May 15, 2025
Original Pull Request: #4964
mp911de
added a commit
that referenced
this pull request
May 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See spring-projects/spring-data-commons#3282