Skip to content

test: Pass fake api_key to the internal ai model#764

Merged
szykol merged 1 commit intodevelopfrom
skolton/e2e-fixes
May 5, 2026
Merged

test: Pass fake api_key to the internal ai model#764
szykol merged 1 commit intodevelopfrom
skolton/e2e-fixes

Conversation

@szykol
Copy link
Copy Markdown
Collaborator

@szykol szykol commented May 5, 2026

The new version of openai library (v2.34.0) requires the api_key to be non-empty.
This fails our e2e tests, since we didn't use the api_key.
This PR fixes this by passing some fake api_key to the OpenAIModel for tests.

Copy link
Copy Markdown
Member

@mateusz834 mateusz834 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the description and title, since this is no longer a test.

@szykol szykol force-pushed the skolton/e2e-fixes branch from c90e431 to f2571b1 Compare May 5, 2026 12:34
@szykol szykol force-pushed the skolton/e2e-fixes branch from f2571b1 to e1778ea Compare May 5, 2026 12:39
@szykol
Copy link
Copy Markdown
Collaborator Author

szykol commented May 5, 2026

Sorry for poor wording, I wanted to note that this is related to tests only, not that this was used for testing.

@szykol szykol merged commit b764d82 into develop May 5, 2026
4 of 6 checks passed
@szykol szykol deleted the skolton/e2e-fixes branch May 5, 2026 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants