Set kw_only=True in all dataclasses#758
Merged
mateusz834 merged 1 commit intodevelopfrom May 5, 2026
Merged
Conversation
f0c226f to
d256220
Compare
Ickerday
approved these changes
May 4, 2026
szykol
approved these changes
May 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make all public dataclasses keyword-only using
kw_only=Trueto allow flexible field ordering. This enables adding new fields or reordering existing ones without breaking positional initialization. This is important in terms of backwards compatibility of the SDK.