Skip to content

Add support for --api-versions flag for helm template #257

Closed
kvaps wants to merge 2 commits into
splunk:mainfrom
kvaps:helm-apiversions
Closed

Add support for --api-versions flag for helm template #257
kvaps wants to merge 2 commits into
splunk:mainfrom
kvaps:helm-apiversions

Conversation

@kvaps

@kvaps kvaps commented Sep 17, 2021

Copy link
Copy Markdown
Contributor

This PR adds support for passing --api-versions to helm template command.
Many charts containing lookup functions, which allow to check if Kubernetes cluster supports specific apiVersions
https://helm.sh/docs/chart_template_guide/functions_and_pipelines/#using-the-lookup-function

@kvaps kvaps changed the title Add --api-versions flag support for helm template Add support for --api-versions flag for helm template Sep 17, 2021
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

Merging #257 (c6695dc) into master (5508c45) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #257      +/-   ##
==========================================
+ Coverage   73.87%   73.88%   +0.01%     
==========================================
  Files          72       72              
  Lines        5015     5017       +2     
==========================================
+ Hits         3705     3707       +2     
  Misses       1101     1101              
  Partials      209      209              
Impacted Files Coverage Δ
vm/internal/natives/helm.go 90.24% <100.00%> (+0.50%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5508c45...c6695dc. Read the comment docs.

@harsimranmaan

Copy link
Copy Markdown
Contributor

@kvaps qbec know supports external datasources https://qbec.io/reference/jsonnet-external-data/. It is possible to use helm(or any other tool) in a generic way without requiring native functions. @gotwarlost maybe we should looking at dropping the expandHelmTemplate in a future release

@Andor

Andor commented Nov 27, 2023

Copy link
Copy Markdown

@harsimranmaan since #286 function expandHelmTemplate might be considered as a stable one. Could you please merge this change?

@michael-burt

Copy link
Copy Markdown
Collaborator

This functionality is in the helm3 datasource.

@github-actions github-actions Bot locked and limited conversation to collaborators Apr 12, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants