Skip to content

[test]: Backend unit test for the Equal operator in QueryOps#8294

Open
rijulpoudel wants to merge 19 commits into
mainfrom
issue-8293
Open

[test]: Backend unit test for the Equal operator in QueryOps#8294
rijulpoudel wants to merge 19 commits into
mainfrom
issue-8293

Conversation

@rijulpoudel

@rijulpoudel rijulpoudel commented Jul 10, 2026

Copy link
Copy Markdown
Collaborator

Fixes #8293

Summary by CodeRabbit

  • Tests
    • Expanded automated coverage for query operators, including comparisons, ranges, membership, pattern matching, empty values, and boolean conditions.
    • Added validation for null and tri-state boolean filtering behavior.

@coderabbitai

coderabbitai Bot commented Jul 10, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 2d5675c5-f2ee-439e-a88f-8c102feba13e

📥 Commits

Reviewing files that changed from the base of the PR and between 2194759 and fb46fcb.

📒 Files selected for processing (1)
  • specifyweb/backend/stored_queries/tests/test_query_ops.py

📝 Walkthrough

Walkthrough

Changes

QueryOps test coverage

Layer / File(s) Summary
Operator SQL-generation coverage
specifyweb/backend/stored_queries/tests/test_query_ops.py
Adds assert_op_sql tests for equality, string and numeric comparisons, ranges, membership, null handling, boolean filters, and boolean-or-null operators.

Possibly related issues

Possibly related PRs

🚥 Pre-merge checks | ✅ 5 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Out of Scope Changes check ⚠️ Warning The PR adds several QueryOps tests beyond the linked Equal-operator scope, including comparisons, membership, and boolean variants. Keep only the Equal-operator cases in this PR, or split the broader QueryOps coverage into a separate change.
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title is concise and accurately describes the main change: backend unit tests for QueryOps equality.
Linked Issues check ✅ Passed The added tests cover the requested Equal operator behavior in QueryOps, so the linked issue is satisfied.
Automatic Tests ✅ Passed PASS: The PR adds backend unit tests in specifyweb/backend/stored_queries/tests/test_query_ops.py, with multiple test_* cases covering QueryOps operators.
Testing Instructions ✅ Passed PASS: TestQueryOps directly targets query_ops.QueryOps and adds explicit SQL assertions for equal and related operators, matching the affected component.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch issue-8293

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@rijulpoudel rijulpoudel changed the title Issue 8293 [test]: Backend unit test for the Equal operator in QueryOps Jul 10, 2026
@github-actions

github-actions Bot commented Jul 10, 2026

Copy link
Copy Markdown

Warning

One or more dependencies are approaching or past End-of-Life.
Please plan upgrades accordingly.

STATUS=WARNING
NODE_VERSION=20
NODE_CYCLE=20
EOL_DATE=2026-04-30
DAYS_REMAINING=-76

--- Node.js ---
Version: 20
EOL: 2026-04-30
Status: WARNING

STATUS=OK
PYTHON_VERSION=3.12
PYTHON_CYCLE=3.12
EOL_DATE=2028-10-31
DAYS_REMAINING=839

--- Python ---
Version: 3.12
EOL: 2028-10-31
Status: OK

STATUS=WARNING
DJANGO_VERSION=4.2
DJANGO_CYCLE=4.2
EOL_DATE=2026-04-07
DAYS_REMAINING=-99

--- Django ---
Version: 4.2
EOL: 2026-04-07
Status: WARNING


@rijulpoudel

Copy link
Copy Markdown
Collaborator Author

@CodeRabbit Full Review

@coderabbitai

coderabbitai Bot commented Jul 10, 2026

Copy link
Copy Markdown
Contributor
✅ Action performed

Full review finished.


Your plan includes PR reviews subject to rate limits. More reviews will be available in 25 minutes.

Base automatically changed from issue-8291 to main July 13, 2026 07:13
[test]: Backend unit tests for remaining simple QueryOps operators (Greater than, Less than, Greater or equal, Less or equal, Between, Contains, In, Starts with, Ends with, Empty, True, False, TrueOrNull, FalseOrNull)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: 📋Back Log

Development

Successfully merging this pull request may close these issues.

[test]: Backend unit test for the Equal operator in QueryOps

2 participants