QueryBuilder: Show catalognumber format tool when mapped to-many - #6994
Merged
Conversation
CarolineDenis
approved these changes
Jul 10, 2025
Triggered by ad6e87c on branch refs/heads/issue-6990
emenslin
approved these changes
Aug 6, 2025
emenslin
left a comment
Collaborator
There was a problem hiding this comment.
- Ensure the gear icon appears next to the query field, and it allows you to select the Catalog Number format for the field
- Ensure the gear icon appears next to the query field, and it allows you to select the Catalog Number format for the field
bhumikaguptaa
approved these changes
Aug 8, 2025
bhumikaguptaa
left a comment
Collaborator
There was a problem hiding this comment.
- Ensure the gear icon appears next to the query field, and it allows you to select the Catalog Number format for the field
- Ensure the gear icon appears next to the query field, and it allows you to select the Catalog Number format for the field
Works as expected! The gear icon appears.
Triggered by 25a26ac on branch refs/heads/issue-6990
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Fixes #6990
The underlying Issue here stemmed from the fact that both the WorkBench and QueryBuilder maintains indices when mapping to-many relationships: for example a mapping of
CollectionObject -> determinationsmight be mapped "behind the scenes" asCollectionObject -> determinations -> #1. In the WorkBench, if a second Determination is mapped then it would be mapped asCollectionObject -> determinations -> #2, and so.For #5485 when determining the terminating field of the query line/filter, it would use the internal mapping path (including to-many indices). This PR removes to-many indices from the mapping path when determining the terminating field.
Checklist
self-explanatory (or properly documented)
Testing instructions
Ensure there are at least two CollectionObjectTypes in the Collection which have different CatalogNumberFormatNames
Open or go to a new query for a base table which is not CollectionObject, but has a path to CollectionObject along which there is a least one to-many relationship.
Add
CollectionObject -> catalogNumberto the query, and change the filter fromAnyto any filter which expects the format to be preserved (any ofEqual,Greater than,Greater than or equal to,Less than,Less than or equal to,BetweenorIn)Ensure the gear icon appears next to the query field, and it allows you to select the Catalog Number format for the field
Open or go to a new query for a base table which has a path to CollectionObject along which there are no to-many relationships
CollectionObject -> catalogNumberto the query, and change the filter fromAnyto any filter which expects the format to be preserved (any ofEqual,Greater than,Greater than or equal to,Less than,Less than or equal to,BetweenorIn)