Move businessrules app under backend/businessrules#6778
Conversation
businessrules under backend/businessrulesbusinessrules app under backend/businessrules
bhumikaguptaa
left a comment
There was a problem hiding this comment.
[X] General Business Rules testing
- [X] Verify that save is blocked and a Field is required. points to a required empty field
- [X] Ensure that save blockers work the same as main on other tables (e.g. Taxon, Collection Object)
- [X] Verify that the rule is respected and behavior is identical to main
Works as expected!
emenslin
left a comment
There was a problem hiding this comment.
- General Business Rules testing (additional gen testing in addition to the ones below)
-
Verify that save is blocked and a Field is required. points to a required empty field
-
Ensure that save blockers work the same as
mainon other tables (e.g. Taxon, Collection Object) -
Verify that the rule is respected and behavior is identical to
main
-
Issues:
- If you add accession agents but don't fill out the fields you can't save but the save button also doesn't turn red. This happens in seemingly all other forms if you don't fill out the required field the field turns red but the save button stays orange.
Issue branch:
07-03_10.21.mp4
Main:
07-03_10.22.mp4
- Similarly there is also no save blocker if you uncheck 'is current' under determination on the CO form so you can save without a current determination.
Issue branch:
07-03_10.28.mp4
Main:
07-03_10.29.mp4
- There is an issue with uniqueness rules where sometimes you can save an invalid form (possibly related to #4800 but does not happen in main) also could be related to the save blocker issues I mentioned above.
Issue branch:
07-03_10.36.mp4
Crash report: Specify 7 Crash Report - 2025-07-03T15_36_57.593Z.txt
Main:
07-03_10.37.mp4
|
@emenslin thanks for your review! All issues should be fixed now - please try it out again! |
emenslin
left a comment
There was a problem hiding this comment.
- General Business Rules testing (additional gen testing in addition to the ones below)
- Verify that save is blocked and a Field is required. points to a required empty field
- Ensure that save blockers work the same as
mainon other tables (e.g. Taxon, Collection Object) - Verify that the rule is respected and behavior is identical to
main
Looks good, all behavior seems to be identical to main
Fixes #6777
This PR reorganizes the project structure by moving the
businessrulesapp into a newbackend/businessrules/directory underspecifyweb/.Summary of Changes:
businessrulestospecifyweb/backend/businessrules/SPECIFY_APPSinsettings.pyto includespecifyweb.backend.businessrulesThis is the 13th PR in a broader backend reorganization. No frontend behavior or functionality was changed.
Notes:
exportapp underbackend/export#6770.Checklist
self-explanatory (or properly documented)
Testing instructions
Relevant Documentation: Uniqueness Rules & Business Rules
Please cross check the following functionalities with
main:General Business Rules testing (additional gen testing in addition to the ones below)
mainon other tables (e.g. Taxon, Collection Object)main