Improve DataObjFormatters Handling for New Tables#6324
Merged
Conversation
Areyes42
marked this pull request as ready for review
April 11, 2025 19:28
Triggered by ea75ff1 on branch refs/heads/issue-6243
emenslin
requested changes
Apr 11, 2025
emenslin
left a comment
Collaborator
There was a problem hiding this comment.
- Verify the records are displayed with proper formatting
- Repeat these steps with all the affected tables
- Verify records are properly formatted when using the search button in the query combo box
- Verify the new custom formatter overrides the system formatter
TectonicUnitTreeDef and TectonicUnitTreeDefItem don't have a default format, everything else looks good!
Contributor
Author
I added those two tables to the default dataobj formatters, so they should be good now. |
sharadsw
approved these changes
Apr 16, 2025
sharadsw
left a comment
Contributor
There was a problem hiding this comment.
I think the changes here look good! My comments are just for discussion on trying to generalize fallback for all app resources instead of having different logic for different ones
emenslin
approved these changes
Apr 18, 2025
CarolineDenis
approved these changes
Apr 18, 2025
pashiav
approved these changes
Apr 23, 2025
pashiav
left a comment
Contributor
There was a problem hiding this comment.
- Verify the records are displayed with proper formatting
- Repeat these steps with all the affected tables
- Verify records are properly formatted when using the search button in the query combo box
- Verify the new custom formatter overrides the system formatter
Looks good! Working as expected.
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Fixes #6243
Refer to the original issue for more detailed context, but essentially this PR implements a fallback mechanism for DataObjFormatters that allows users with custom configurations to merge with default presets. This change should let users with custom DataObjFormatters now automatically access new table formatters added to the system without needing to manually update their configs.
Specifically affected tables include:
specifyusercollectionobjectgroupcollectionobjecttypecollectionobjectgrouptypetectonicunittectonicunittreedeftectonicunittreedefitemChecklist
self-explanatory (or properly documented)
Testing instructions